Skip to content

feat: Add advice override for 'MISSING_TRIGGER_FUNCTION' #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimothyJones merged 2 commits into from
Jul 18, 2026
Merged

feat: Add advice override for 'MISSING_TRIGGER_FUNCTION' #1352

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcc9830
Add advice override for 'MISSING_TRIGGER_FUNCTION'
JamesBurnsCanva Jul 17, 2026
1b01e19
Merge branch 'main' into 20260716-missing-trigger-advice-override
TimothyJones Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions packages/case-core/src/core/executeExample/triggers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ import type { InvokingScaffold, Trigger } from './types';
import { Assertable } from '../../entities/types';
import { CaseFailedAssertionError } from '../../entities';

const advice = (context: MatchContext) =>

@TimothyJones TimothyJones Jul 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's call this missingTriggerAdvice, as it's defined quite a long way from where it's used.

context['_case:currentRun:context:adviceOverrides']?.[
'MISSING_TRIGGER_FUNCTION'
] ?? `Please check that you have configured the appropriate trigger function`;

const invokeTrigger = <T extends AnyMockDescriptorType, R>(
trigger: Trigger<T, R>,
testResponse: (data: R, config: Assertable<T>['config']) => unknown,
Expand Down Expand Up @@ -213,7 +218,7 @@ export const findAndCallTrigger = <T extends AnyMockDescriptorType, R>(
`No trigger for request '${names.requestName}' provided`,
);
throw new CaseConfigurationError(
`No trigger provided for request:\n ${names.requestName}`,
`No trigger provided for request:\n ${names.requestName}\n\n${advice(context)}`,
context,
'MISSING_TRIGGER_FUNCTION',
);
Expand Down Expand Up @@ -251,22 +256,20 @@ export const findAndCallTrigger = <T extends AnyMockDescriptorType, R>(
names.responseName
}\n However, tests for that response name do exist in the following configurations:\n${endsWith
.map((s) => ` ${s.split('::')[0]}`)
.join(
'\n',
)}\n\nPlease check that you have configured the appropriate trigger function\n`,
.join('\n')}\n\n${advice(context)}\n`,
context,
'MISSING_TRIGGER_FUNCTION',
);
}

throw new CaseConfigurationError(
`Missing a trigger for:\n ${names.requestName}\n this should be paired with a test for:\n ${names.responseName}`,
`Missing a trigger for:\n ${names.requestName}\n this should be paired with a test for:\n ${names.responseName}\n\n${advice(context)}`,
context,
'MISSING_TRIGGER_FUNCTION',
);
}
throw new CaseConfigurationError(
`No trigger or trigger map provided for:\n ${names.requestName}\n You must set a trigger or a trigger map`,
`No trigger or trigger map provided for:\n ${names.requestName}\n You must set a trigger or a trigger map\n\n${advice(context)}`,
context,
'MISSING_TRIGGER_FUNCTION',
);
Expand Down
Loading