Skip to content

[workflows-shared] Support object-form createBatch in local development - #15777

Merged
Naapperas merged 5 commits into
mainfrom
nunopereira/workflows-create-batch-v2
Oct 1, 2026
Merged

Naapperas merged 5 commits into
mainfrom
nunopereira/workflows-create-batch-v2

Conversation

@Naapperas

@Naapperas Naapperas commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Fixes WOR-1452.

Implements local-dev behavior for the new BatchCreate V2 API being released for Workflows.

Docs pending.


A picture of a cute animal (not mandatory, but encouraged)

A cute red panda in the snow

@changeset-bot

changeset-bot Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fa7e34a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
miniflare Minor
wrangler Minor
@cloudflare/deploy-helpers Patch
@cloudflare/pages-shared Patch
@cloudflare/remote-bindings Patch
@cloudflare/runtime-types Patch
@cloudflare/vite-plugin Patch
@cloudflare/vitest-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ask-bonk[bot]

This comment was marked as resolved.

@ask-bonk

ask-bonk Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

I'm Bonk, and I've done a quick review of your PR.

Adds local object-form Workflow createBatch() support with per-instance errors.

  1. P1 packages/miniflare/src/workers/workflows/wrapped-binding.worker.ts:38: public @cloudflare/workers-types still only accepts array-form batches, so TypeScript Workers cannot compile the new API. Add the matching declaration upstream and bump the dependency.

Posted 1 inline suggestion comment.

github run

@Naapperas
Naapperas force-pushed the nunopereira/workflows-create-batch-v2 branch from eabcfd1 to ff28693 Compare September 22, 2026 15:34
@pkg-pr-new

pkg-pr-new Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15777

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15777

@cloudflare/codemods

npm i https://pkg.pr.new/@cloudflare/codemods@15777

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15777

@cloudflare/containers-shared

npm i https://pkg.pr.new/@cloudflare/containers-shared@15777

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15777

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15777

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15777

miniflare

npm i https://pkg.pr.new/miniflare@15777

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15777

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15777

@cloudflare/runtime-types

npm i https://pkg.pr.new/@cloudflare/runtime-types@15777

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15777

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15777

@cloudflare/vitest-plugin

npm i https://pkg.pr.new/@cloudflare/vitest-plugin@15777

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15777

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15777

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15777

wrangler

npm i https://pkg.pr.new/wrangler@15777

commit: fa7e34a

@Naapperas
Naapperas marked this pull request as ready for review September 22, 2026 17:34
@workers-devprod
workers-devprod requested review from a team and cjol and removed request for a team September 22, 2026 17:34
@workers-devprod

workers-devprod commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/workflows
  • ✅ @cloudflare/wrangler
Show detailed file reviewers
  • packages/workflows-shared/src/binding.ts: [@cloudflare/workflows]
  • packages/workflows-shared/tests/binding.test.ts: [@cloudflare/workflows]

devin-ai-integration[bot]

This comment was marked as resolved.

@Naapperas

Copy link
Copy Markdown
Contributor Author

Re the @cloudflare/workers-types finding: the object-form createBatch() declaration is up in cloudflare/workerd#7272. The latest published @cloudflare/workers-types (5.20260923.1) still only declares the array form, so the catalog version will be bumped in a follow-up once that change is released.

@Naapperas Naapperas changed the title Nunopereira/workflows create batch v2 [workflows-shared] Support object-form createBatch in local development Sep 23, 2026
@Naapperas
Naapperas force-pushed the nunopereira/workflows-create-batch-v2 branch from 9eecb01 to ec26396 Compare September 24, 2026 16:31
devin-ai-integration[bot]

This comment was marked as resolved.

@workers-devprod

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • ✅ @cloudflare/workflows
  • ✅ @cloudflare/wrangler
Show detailed file reviewers

@workers-devprod workers-devprod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeowners reviews satisfied

@Naapperas
Naapperas force-pushed the nunopereira/workflows-create-batch-v2 branch 2 times, most recently from 5d6b05e to e29cb8b Compare September 30, 2026 13:14
@Naapperas
Naapperas force-pushed the nunopereira/workflows-create-batch-v2 branch from e29cb8b to fa7e34a Compare September 30, 2026 15:38
@Naapperas
Naapperas merged commit 464a582 into main Oct 1, 2026
67 of 71 checks passed
@Naapperas
Naapperas deleted the nunopereira/workflows-create-batch-v2 branch October 1, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants