Order student packets activity-before-notes to match EFFL - #54
Open
code-layne wants to merge 1 commit into
Open
Conversation
STUDENT_ORDER sat under a comment reading "in pedagogical order" but listed notes ahead of activity, so every built student packet handed students the formal notes before the activity those notes are supposed to come out of — the opposite of the experience-first-formalize-later approach the department teaches. Swap the two. KEY_COMPS is derived from STUDENT_COMPS, so the key packet follows automatically and the two stay paired 1:1 for the pagination pass. KEYED_PAIRS is reordered for consistency only; nothing reads it. Verified on unit01/lesson03: merge order is now cover, warmup, activity, notes, exit_ticket, homework in both packets; student and key both come out at 12 pages and every component matches its _key page for page. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
One line in
shared/lesson.mk:plus a comment explaining why the order is what it is, and a matching reorder of
KEYED_PAIRS.Why
The line sat under a comment reading "Component discovery (in pedagogical order)" but listed
notesahead ofactivity. Every built student packet therefore handed students the formal notes before the activity those notes are supposed to emerge from — the exact inverse of the experience-first-formalize-later approach used across the math department.This surfaced while writing the Advanced Statistics syllabus, whose Course Description now states that formal notes are "the product of the lesson, not its starting point." The packet contradicted the syllabus.
Reviewer notes
KEY_COMPSis derived fromSTUDENT_COMPS, not fromKEYED_PAIRS, so the key packet follows the new order automatically and the two packets stay paired 1:1 for the pagination pass.KEYED_PAIRSis dead — defined here and referenced only inside a comment, never read by any rule. Reordered for consistency; could reasonably be deleted in a separate change..texcontent was touched.Verification
make -C unit01/lesson03 student keyexits 0. Thepdfuniteinvocation now mergescover, warmup, activity, notes, exit_ticket, homeworkfor the student packet and the corresponding_keycomponents for the key packet.lesson03_student.pdflesson03_key.pdfOnly
unit01/lesson03was rebuilt; a fullmakeacross all 80 lessons has not been run.🤖 Generated with Claude Code