Repository navigation
Ignore the dead meetings.invites_sent column - #3022
Merged
mroderick merged 3 commits intoOct 13, 2026
Merged
Conversation
The meetings.invites_sent boolean has been dead since 2020. Its last read and write were removed in 39bbbe5 (2020-12-02), which tracked the intent to drop it later. Nothing has referenced the column since. Ignore the column before dropping it. Old releases build their meeting SELECT list from their schema cache and name every column explicitly, so a drop while old dynos still serve under Heroku preboot would fail every meeting query on them. The removal itself is a safety_assured remove_column in a separate deploy. Part of codebar#3017.
olleolleolle
approved these changes
Oct 13, 2026
mroderick
marked this pull request as ready for review
October 13, 2026 14:06
mroderick
enabled auto-merge
October 13, 2026 14:07
mroderick
added a commit
that referenced
this pull request
Oct 13, 2026
Step 2 of #3017. The meetings.invites_sent boolean has been dead since 39bbbe5 (2020-12-02) removed its last read and write. The absence is pinned in the meeting spec with a column_exists check. Merge only after the ignored_columns change (#3022) has deployed: old releases name the column in their meeting SELECT list, built from the schema cache at boot, and dropping it while they still serve would fail every meeting query during the Heroku preboot switch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
First half of #3017 (per the plan in #3015).
meetings.invites_sentis a boolean, defaultfalse, that tracked whether a meeting's invite batch had gone out. The last read and the last write were removed in39bbbe52(2020-12-02, "Ignore invites_sent column from now on"); that commit records the intent to drop the column later. Nothing has referenced it since, and it still loads on every meeting query.Following the same two-step removal as #3007: ignore the column in this PR, drop it with a
safety_assuredremove_columnin a follow-up PR.Why the ignore step is load-bearing
Production runs with Heroku preboot: the release phase runs migrations before new dynos boot, and old dynos keep serving against the new schema during the window. Rails 8.1 builds explicit column lists (
SELECT "meetings"."id", ..., "meetings"."invites_sent", ...), so dropping the column while old dynos serve would fail every meeting query on them withPG::UndefinedColumn.Changes
invites_senttoself.ignored_columnsonMeeting.Meeting.newno longer responds toinvites_sent.Acceptance
Meeting.ignored_columnsincludesinvites_sent;Meeting.all.to_sqlno longer names the column.make test(1729 examples, 0 failures).rubocopclean on both touched files.Review notes
unsubscribedignore PR). The follow-up PR will remove theignored_columnsentry, add the migration, and regenerateschema.rb.