🤖 feat: add copy-file button to immersive review file view - #3919
🤖 feat: add copy-file button to immersive review file view#3919ibetitsmike wants to merge 19 commits into
Conversation
Fixes #2842: the file view had no way to copy the whole file, and Ctrl+A selects beyond the viewed file. Adds a header button plus the 'y' keybind that read the entire on-disk file (bypassing the overlay's 1500-line/256KB display budget) and copy it to the clipboard.
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d6681f401
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
… reads Codex review: discard copy completions after navigating files, hide the button for deleted files, and reject IPC-truncated reads instead of silently copying a partial file.
|
@codex review |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 50c6f938c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Derive deleted-file state from unfiltered hunks so filtered-out files stay gated, copy SVG markup as text instead of rejecting it as an image, and drop the keybind value from the handler comment.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c95042f20
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Security Review
Here are some automated security review suggestions for this pull request.
Reviewed commit: 5c95042f20
Only the user who started this review can view the report in Codex.
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
Derive deletion from file-tree numstat so hunk-less deletions stay gated, anchor relative read paths with ./ so option-like names (-n) read correctly, and surface copy failures on the button instead of only logging to the console.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cc2c698ce2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex security finding: a changed symlink pointing outside the workspace let the copy action (and the shared overlay read path) read arbitrary external files. buildReadFileScript now fails closed with exit 44 when the physically resolved path escapes the execution root; in-workspace symlinks still read normally.
|
@codex review |
Drop the manual useMemo (React Compiler convention) and invalidate in-flight copies on unmount so a late read cannot overwrite the clipboard after leaving immersive review.
This comment has been minimized.
This comment has been minimized.
|
@codex review |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a4c418f4b9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Replace the new useCallbacks with plain functions (React Compiler convention), route the keyboard path through a ref like the file's other handlers, and announce copy outcomes via an sr-only live region so the keyboard shortcut result reaches assistive technology.
|
@codex review |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fcc1bf5570
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Run copy reads from the repo root for single-project workspaces (multi-project hunk paths stay container-root-relative and keep default mode), and reject unsuccessful script exits so partial output like a lone stat size can never be copied as empty text.
|
@codex review |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d488f2d75
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Security Review
Here are some automated security review suggestions for this pull request.
Reviewed commit: fa11fa1620
Only the user who started this review can view the report in Codex.
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
Codex ABA finding: navigating A -> B -> A while a copy of A was in flight let the stale read pass the path check and reach the clipboard, while the pending slot blocked a replacement copy. Navigation now bumps the request generation and frees the slot.
|
@codex review |
1 similar comment
|
@codex review |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b7b73da09e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b7b73da09e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Security Review
Here are some automated security review suggestions for this pull request.
Reviewed commit: b7b73da09e
Only the user who started this review can view the report in Codex.
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
Codex finding: an agent edit or diff refresh changes the same path's content version while a copy read is pending, so the stale result could reach the clipboard and report success against the new diff. The invalidation effect and feedback identity now include the file's content version.
|
@codex review |
Codex finding: parseNumstat trimmed the whole output, so the LAST line's path lost trailing whitespace (a file literally named '.env ' became '.env') and downstream reads targeted the wrong file. Split lines before filtering instead.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7748b85bd6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex finding: the size-check test asserted the exact realpath command string; a plain end-to-end bash read validates the same script without pinning implementation literals.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9fd96cc684
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex finding: base64 expansion pushed files over ~780KB past the 1MiB IPC output cap, so copies of ordinary sub-10MB files always failed with a generic message. Copies now use a deterministic 750KB budget and report the size limit when exceeded.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ed0da1da1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Replace the generated-shell literal assertion with a real-bash red-green pair (oversized file exits too-large with no payload; in-budget file reads fully) in fileRead.test.ts.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d7c9510e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Security Review
Here are some automated security review suggestions for this pull request.
Reviewed commit: 5d7c9510e4
Only the user who started this review can view the report in Codex.
ℹ️ About Codex security reviews in GitHub
This is an experimental Codex feature. Security reviews are triggered when:
- You comment "@codex security review"
- A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review
Once complete, Codex will leave suggestions, or a comment if no findings are found.
Stop trimming whole name-status output so trailing-space paths keep their change status (matching the numstat fix), and show a visible failure when copy is invoked while the backend API is unavailable.
|
@codex review |
Codex finding: reprojectRepoRootFilePath trimmed file paths, undoing the parser fixes downstream (a file named '.env ' again read '.env'). File-path normalization now keeps edge whitespace; trimming remains only for config-controlled project paths.
|
@codex review |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4922182406
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // swapping the symlink between validation and read cannot redirect the read. | ||
| return `${anchorScript} | ||
| [ -n "$anchor" ] || exit ${EXIT_CODE_OUTSIDE_WORKSPACE} | ||
| resolved=$(realpath ${file} 2>/dev/null || readlink -f ${file} 2>/dev/null) |
There was a problem hiding this comment.
On older macOS or remote BSD environments that provide neither realpath nor GNU readlink -f, both commands fail and resolved is empty, so every full-file overlay read and Copy action exits as “outside workspace” even for ordinary files. The repository already models the relevant BSD/macOS behavior in src/node/services/tools/mux_agents.test.ts:248-257; use a portable resolver or perform containment and reading in the Node backend.
Useful? React with 👍 / 👎.
| try { | ||
| const result = await api.workspace.executeBash({ | ||
| workspaceId: props.workspaceId, | ||
| script: buildReadFileScript(filePath, { |
There was a problem hiding this comment.
In a trusted workspace whose .mux/tool_env prints anything during activation, this read no longer starts with the expected size line: src/node/services/tools/bash.ts:828-835 prepends source ... 2>&1, so even a harmless echo ready makes processFileContents reject every Copy attempt (and can also break full-file hydration). Frame the payload with unambiguous sentinels, suppress prelude output for this IPC, or use a dedicated file-read API.
AGENTS.md reference: AGENTS.md:L52-L52
Useful? React with 👍 / 👎.
1 participant
Summary
Adds a "copy file" button (and a
ykeyboard shortcut) to the immersive review file view that copies the entire viewed file's text to the clipboard.Fixes #2842
Background
The file view offers no way to copy the whole file: Ctrl+A selects content beyond the viewed file. The issue predates the removal of the Explorer file viewer (#3208); the immersive review view is the current single-file surface, so the affordance lands in its header.
Implementation
REVIEW_COPY_FILE(y) keybind, wired into the existing immersive keydown handler so editable-element, dialog, notes-panel, and touch gating apply for free. Surfaced in Settings → Keybinds under Immersive Review.Copyicon flipping toCheckwith the shared tooltip (Copy file (Y), shortcut hint hidden on mobile). Hidden when the review is complete.buildReadFileScriptwithout display budgets, so it yields the entire on-disk file even when the overlay fell back to compact hunks (>1500 lines / 256KB); non-text (binary/image) results are rejected.Validation
make static-check, targeted unit tests (ImmersiveReviewView.test.tsx: full-file copy under a line-budgeted display read, keybind + editable-element guard, hidden-on-complete), andtests/ui/review.Generated with
mux• Model:anthropic:claude-fable-5• Thinking:xhigh