-
Notifications
You must be signed in to change notification settings - Fork 134
🤖 feat: add copy-file button to immersive review file view #3919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ibetitsmike
wants to merge
23
commits into
main
Choose a base branch
from
mike/fix-2842-copy-file-button
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
5d6681f
feat: add copy-file button and keybind to immersive review
ibetitsmike 50c6f93
fix: harden immersive copy-file against stale, deleted, and truncated…
ibetitsmike 5c95042
fix: address Codex round-2 findings on immersive copy-file
ibetitsmike cc2c698
fix: address Codex round-3 findings on immersive copy-file
ibetitsmike bed4812
fix: reject file reads that resolve outside the workspace
ibetitsmike a4c418f
fix: address Codex round-4 findings on immersive copy-file
ibetitsmike fcc1bf5
fix: address Codex round-5 findings on immersive copy-file
ibetitsmike 2d488f2
fix: address Codex round-6 findings on immersive copy-file
ibetitsmike 321d6e2
fix: address Codex round-7 findings on immersive copy-file
ibetitsmike da11eb8
fix: address Codex round-8 findings on immersive copy-file
ibetitsmike fa11fa1
tests: address Codex round-9 test-quality findings
ibetitsmike b7b73da
fix: invalidate pending copies on every file navigation
ibetitsmike 67ffb23
fix: invalidate pending copies when the file changes in place
ibetitsmike 7748b85
fix: preserve trailing whitespace in numstat file paths
ibetitsmike 9fd96cc
tests: replace generated-shell literal assertion with a behavioral read
ibetitsmike 4ed0da1
fix: cap copy reads at the IPC-safe size with a clear failure message
ibetitsmike 5d7c951
tests: exercise the copy size budget behaviorally
ibetitsmike 93ab156
fix: address Codex round-18 findings on immersive copy-file
ibetitsmike 4922182
fix: preserve edge whitespace in git file paths through reprojection
ibetitsmike 02c0237
fix: address Codex round-20 findings on the shared read script
ibetitsmike cf6b42a
fix: silence shell diagnostics around the framed read payload
ibetitsmike 07e4cf9
fix: reject symlinks at the read path's final component
ibetitsmike 6054f49
fix: address Codex round-23 findings on immersive copy-file
ibetitsmike File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
652 changes: 651 additions & 1 deletion
652
src/browser/features/RightSidebar/CodeReview/ImmersiveReviewView.test.tsx
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.