Skip to content

fix(page): build the PR search link from the program's repos #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bfs2021 wants to merge 1 commit into from
Closed

fix(page): build the PR search link from the program's repos #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ async function handleContributor(
return response;
}

const prsQuery = `org:${cfg.org} is:pr is:merged author:${row.login} label:"${program.label}" merged:${program.start.toISOString().slice(0, 10)}..${program.end.toISOString().slice(0, 10)}`;
const prsQuery = ["is:pr","is:merged",`author:${row.login}`,`label:"${program.label}"`,`merged:${program.start.toISOString().slice(0, 10)}..${program.end.toISOString().slice(0, 10)}`,...program.repos.map((r) => `repo:${cfg.org}/${r}`),].join(" ");
const html = contributorPage(
{ program, row, rank, of, generatedAt: board.generatedAt },
{
Expand Down
16 changes: 15 additions & 1 deletion test/card.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,20 @@ describe("contributorPage", () => {
expect(html).toContain('<a href="/leaderboard/2026-10">Hacktoberfest 2026 leaderboard</a>');
});

it("renders the prs link it is given, repos-qualified not org-wide (#101)", () => {
const reposLink = {
...links,
prs: "https://github.com/search?" + new URLSearchParams({
q: ['is:pr', 'is:merged', 'author:ada', 'label:"hacktoberfest-accepted"',
"merged:2026-10-01..2026-10-31", "repo:codercops/chatcops", "repo:codercops/ogcops"].join(" "),
type: "pullrequests",
}),
};
const reposHtml = contributorPage({ program, row: row("ada", 4), rank: 1, of: 15, generatedAt }, reposLink, during);
expect(reposHtml).toContain(encodeURIComponent('repo:codercops/chatcops'));
expect(reposHtml).not.toContain(encodeURIComponent('org:codercops'));
});

it("has what a share preview needs", () => {
expect(html).toContain('<meta property="og:image" content="https://oss.example/leaderboard/2026-10/u/ada.png?v=4-1-15-running">');
expect(html).toContain('<meta property="og:image:width" content="1200">');
Expand Down Expand Up @@ -314,7 +328,7 @@ describe("GET /leaderboard/{id}/u/{login}", () => {
expect(html).toContain("https://bot.example/leaderboard/2026-10/u/Ada.png?v=2-1-2-");
const prs = /href="(https:\/\/github\.com\/search\?[^"]+)"/.exec(html)![1]!.replace(/&amp;/g, "&");
expect(new URL(prs).searchParams.get("q")).toBe(
'org:codercops is:pr is:merged author:Ada label:"hacktoberfest-accepted" merged:2026-10-01..2026-10-31'
'is:pr is:merged author:Ada label:"hacktoberfest-accepted" merged:2026-10-01..2026-10-31 repo:codercops/chatcops repo:codercops/ogcops repo:codercops/toolbelt'
);
});

Expand Down
Loading