Repository navigation
Conversation
…ps#101) The contributor page linked to an org-wide search while the count came from a repos-scoped one, so the link could list PRs the card didn't count. Build the query the same way searchMergedPrs does.
Member
|
Hey @bfs2021, closing this one too and labeling it That's your second spam PR, after toolbelt #346 earlier today. Per the ground rules in CONTRIBUTING.md, two spam PRs means no more issue assignments this month and you're out of the CODERCOPS goodies. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On a contributor card page, "See 's merged pull requests on GitHub" links to a GitHub search built with
org:codercops(src/index.ts). The number on the card comes fromsearchMergedPrs(src/github.ts), which only searches the program's repos (repo:codercops/<repo>for each one). So the link can list PRs the card didn't count — it already does for any program with its ownreposlist. Fixes #101.Fix
prsQueryis now built fromprogram.reposthe same waysearchMergedPrsbuilds its query: same author, label and merged-date window, butrepo:codercops/<repo>per program repo instead oforg:codercops.Testing
test/card.test.ts:org:codercopsshape);renders the prs link it is given, repos-qualified not org-wideasserts the page renders a repos-qualified link and noorg:qualifier.npm run typecheck→ clean.npm test→ 378 passed.src/index.ts(verified by stashing it).