Repository navigation
Remove role memberships on REVOKE role FROM grantee - #175
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlparser now parses
REVOKE role FROM granteeas its own statement (apache/datafusion-sqlparser-rs#2735). sql-traits had no arm for it, so a membership that was granted and later revoked stayed in the catalog. A consumer such as pg2sqlite would then let the member inherit a role that PostgreSQL had taken away.The revoke follows PostgreSQL's own planning in
user.c, and each case was compared against a PostgreSQL 18 server. It removes the grant made by the named grantor, or the grant written without one, andOPTION FORclears only that option. A revoke that reaches no grant changes nothing, because PostgreSQL only warns. Grants a member made with itsADMINoption depend on that option, so taking away its last one is refused unlessCASCADErevokes those grants as well. The grantors the model already records make this possible.The first commit moves the locked sqlparser to the revision that carries apache/datafusion-sqlparser-rs#2735.