Upgrade Ruby and Faraday + bug fixes - #8
Merged
Merged
Conversation
Request#request applied the connection's prefix twice: once baked into the Faraday base URL via Configuration#endpoint, and again via string concatenation. With the default '/' prefix and a caller path that already starts with '/' (e.g. identity-api-client's '/api/member/details'), this produced a leading '//', which Faraday treats as a protocol-relative URL and mangles, yielding malformed URLs like https://host////api/path. Some upstream APIs reject these at the edge with a bare 403. Join prefix and path so they always meet with exactly one slash, regardless of whether either side already has one. This also fixes 5 pre-existing failures in the request spec.
- Bump .ruby-version to 4.0.1; CI now runs the matrix 3.3/3.4/4.0 on actions/checkout@v4 and ruby/setup-ruby@v1 - Remove legacy .ruby-gemset (RVM artifact) - Simplify Gemfile to source + gemspec; move all dependencies into vertebrae.gemspec with explicit version constraints, drop the unused juwelier dev dependency, set required_ruby_version and rubygems_mfa_required - Simplify Rakefile to bundler/gem_tasks + rspec rake task - Add CHANGELOG.md and a Requirements section to the README - Bump version to 2.0.0 (breaking: Ruby floor raised, faraday now pinned ~> 2.0)
ehimen-io
changed the title
ehimen-io
marked this pull request as ready for review
September 28, 2026 16:50
woodhull
approved these changes
Sep 29, 2026
| reject at the edge with a bare 403. | ||
|
|
||
| ### Breaking Changes | ||
| - Dropped support for Ruby versions older than 3.3. Officially supported versions are Ruby 3.3, 3.4, and 4.0. |
Member
There was a problem hiding this comment.
we could also drop 3.3 i think.
Officially supported versions are now 3.4 and 4.0.
3 tasks done
ehimen-io
added a commit
to controlshift/action_kit_rest
that referenced
this pull request
Sep 29, 2026
* Loosen vertebrae dependency to allow 2.x vertebrae 2.0.0 fixes a bug where the request path was built with a duplicated prefix, producing malformed URLs with multiple consecutive slashes for any client passing an already-absolute path (see controlshift/vertebrae#8). The previous ~> 1.0.5 pin blocked upgrading. Verified action_kit_rest's own spec suite (44 examples) passes unchanged against vertebrae 2.0.0. * Bump version to 1.0.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vertebrae::Request#requestapplied the connection'sprefixtwice, so a default/prefix plus an already-absolute path (e.g.identity-api-client's/api/member/details) produced a leading//. Faraday treats that as a protocol-relative URL and mangles it into malformed URLs likehttps://host////api/path.spec/request_spec.rbthat this also fixes), and worth having fixed regardless of whether it explains that incident.~> 2.0, dependencies consolidated into the gemspec, dead Rakefile/Gemfile cruft removed, CHANGELOG added.Test plan
bundle exec rspec— 51 examples, 0 failuresbundle exec rubocop— no offensesbundle installresolves cleanly under Ruby 4.0.1🤖 Generated with Claude Code