Repository navigation
Update cql-tests to 9e92193 and stop skipping RolledOutIntervals on cql-execution - #147
Open
bryantaustin13 wants to merge 1 commit into
Open
bryantaustin13 wants to merge 1 commit into
bryantaustin13 wants to merge 1 commit into
Conversation
…ql-execution cql-tests #146 fixed RolledOutIntervals' starting type from List<Interval<DateTime>> to List<Interval<Date>>, so a correct engine now returns the Date intervals the test expects. The submodule moves from f591d9e to 9e92193, which brings in only that one-line change to CqlAggregateTest.xml. conf/cql-execution-local.json skipped the test because of the old starting type, so that skip is removed. Against the cql-execution test-server the test now passes and no other result changes (1692 -> 1693 pass, 86 -> 85 skip). The other configs' skips are left to #134; on HAPI the test still fails to translate because $cql's FHIR wrapper makes Quantity FHIR.Quantity. Part of #80. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #80.
Problem
RolledOutIntervals(inCqlAggregateTest.xml) usedstarting (null as List<Interval<DateTime>>). That converted the source Date intervals to DateTime, so a correct engine returned a list of DateTime intervals while the expected output is Date intervals. cmoesel'sconf/cql-execution-local.jsonskips the test for that reason:cqframework/cql-tests#146 (merged 2026-09-22) fixed the starting type to
List<Interval<Date>>. The runner'scql-testssubmodule still points atf591d9e, two commits before that fix.The runner side of #80 is already on
main:cqf-cqlType.Change
cql-testssubmodule:f591d9e→9e92193(current cql-testsmain). This brings in only cql-tests#146 and its merge commit, which change one line oftests/cql/CqlAggregateTest.xml.conf/cql-execution-local.json: removes theRolledOutIntervalsskip, since the test it describes is now fixed.The other four configs that skip this test (
localhost,development,smile-cdr-local,localhost-evaluate) are left alone. Their entries are covered by #133 / #134, and on the Java/HAPI stack the test still fails to translate for an unrelated reason. HAPI's$cqlcompiles the expression inside a library withusing FHIR, so the test'sQuantity{ value: …, unit: 'days' }resolves toFHIR.Quantityand itsvalueexpects a FHIRdecimal.Verification
Against the cql-execution
test-server(cql-execution 4.0.0-beta.1 @b1a4c3e,@cqframework/cql5.2.0), withconf/cql-execution-local.json. Both runs use the test files at the exact submodule commit.main, cql-testsf591d9e9e92193RolledOutIntervalsis the only change: skip → pass. No other test changes status or actual value.What the engine returns for the test, before and after the fix:
f591d9e:List<Interval<System.DateTime>>, which the runner correctly scores as a fail against the Date-interval expected output.9e92193:List<Interval<System.Date>>, which passes.Unit tests: 235 pass.
After merging
Anyone using a local clone should run
git submodule update --initto pick up the new test files.Once cmoesel confirms this on their setup, I think #80 can be closed.
🤖 Generated with Claude Code