Repository navigation
Bump Go to 1.27.2 and golangci-lint to v2.14.0 - #7052
Merged
Merged
Conversation
Bump go directive to 1.27.0 and toolchain to go1.27.2 in all modules and golangci-lint to v2.14.0 (first release with go1.27 support). Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
Author
|
Review notes from the upgrade (not applied in this PR): Stdlib could replace a third-party dep
Linters kept but overlapping
Go 1.27 follow-ups worth considering
This pull request and its description were written by Isaac. |
Co-authored-by: Isaac <no-reply@databricks.com>
denik
changed the title
denik
marked this pull request as ready for review
October 14, 2026 14:06
denik
requested review from
a team,
jefferycheng1,
kanterov and
lennartkats-db
as code owners
October 14, 2026 14:06
Collaborator
Integration test reportCommit: 1eb2c88
Top 11 slowest tests (at least 2 minutes):
|
shreyas-goenka
approved these changes
Oct 14, 2026
Collaborator
Integration test reportCommit: 002627a
72 interesting tests: 39 flaky, 33 FAIL
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Bump Go to 1.27.2 (
go 1.27.0) in all modules and golangci-lint to v2.14.0. v2.12 can't read Go 1.27 export data.Lint config:
exhaustruct→exhaustruct_v5, gofumptextra-rules→extra.group-params(both deprecated upstream).Unmarshal*by default instead ofMarshal*, which turned every value-receiverMarshalJSONinto a finding (37). Re-added theMarshal*exclusions.intrange(modernizerangeint), revivecontext-keys-type(SA1029),waitgroup-by-value(govet copylocks),range-val-in-closure(no-op since Go 1.22), ruleguardrule_reflect_typefor(modernizereflecttypefor),rule_os_chdir(usetesting). I checked each one against a probe file.Fixes from the new lint output: modernize
embedlit(Go 1.27 field-selector keys, e.g.resources.Job{Tasks: ...}instead ofresources.Job{JobSettings: jobs.JobSettings{Tasks: ...}}),strings.CutLast, gofumpt 0.12 formatting, two printf bugs found by the new vet check (%dwith*int64,%wwith a pointer error),wg.Go, andnolinton deprecated SDK fields that staticcheck 0.8 now flags in composite literals. Also dropped a manual body drain inlibs/auth/introspect.go, because Go 1.27 drains HTTP/1 bodies onClose.Why
Stay on a supported Go version. Two user-visible effects:
encoding/jsonnow runs on the v2 implementation, and syntax errors point at a different position. For{"a": 1,}the old error was1:9: invalid character '}' looking for beginning of object key string, the new one is1:8: invalid character ',' looking for beginning of value. Updated 3 unit tests and thecmd/api/request-handlinggolden.GOEXPERIMENT=nojsonv2would restore the old behavior, but I didn't use it.Tests
./task checks, golangci-lint (root + tools), all unit tests, and the full acceptance suite pass locally.This pull request and its description were written by Isaac.