Skip to content

Prefer remote DMS markers over stale local state - #7055

Draft
shreyas-goenka wants to merge 1 commit into
shreyas-goenka_data/shreyas-goenka/dms-deploy-migrationfrom
shreyas-goenka_data/shreyas-goenka/dms-marker-selection-stack
Draft

shreyas-goenka wants to merge 1 commit into
shreyas-goenka_data/shreyas-goenka/dms-deploy-migrationfrom
shreyas-goenka_data/shreyas-goenka/dms-marker-selection-stack

Conversation

@shreyas-goenka

Copy link
Copy Markdown
Contributor

Changes

Prefer a valid pulled remote DMS marker over stale local state, regardless of the local serial or deployment-history configuration. Add focused coverage for enabled, disabled, and removed configuration.

Stacked above #6989. Upload suppression and corruption recovery follow separately.

Why

DMS owns recorded resources. The marker's serial will become a checkpoint when routine resources.json uploads are removed, so local file counters must not switch the bundle back to direct state.

Tests

State-management unit tests, scoped Go lint, and the existing state/DMS acceptance suite pass.

Implementation and PR description written with Codex.

@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 09d8036

Run: 38583247773

Env ❌​FAIL 🔄​flaky ✅​pass 🙈​skip Time
❌​ aws linux-2core-8gb 5 3 293 26 22:11
❌​ aws-windows-latest-4core-16gb 5 2 296 24 20:04
❌​ azure linux-2core-8gb 5 295 26 22:27
❌​ azure-windows-latest-4core-16gb 5 2 295 24 20:51
❌​ gcp linux-2core-8gb 5 4 292 26 27:52
❌​ gcp-windows-latest-4core-16gb 5 1 297 24 20:24
17 interesting tests: 12 flaky, 5 FAIL
Test Name aws linux-2core-8gb aws-windows-latest-4core-16gb azure linux-2core-8gb azure-windows-latest-4core-16gb gcp linux-2core-8gb gcp-windows-latest-4core-16gb
❌​ TestAccept ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
🔄​ TestAccept/bundle/dms/declined-deploy ✅​p ✅​p ✅​p 🔄​f ✅​p ✅​p
🔄​ TestAccept/bundle/dms/declined-deploy/DMS=true ✅​p ✅​p ✅​p 🔄​f ✅​p ✅​p
🔄​ TestAccept/bundle/dms/depends-on ✅​p 🔄​f ✅​p ✅​p ✅​p ✅​p
🔄​ TestAccept/bundle/dms/depends-on/DMS=true ✅​p 🔄​f ✅​p ✅​p ✅​p ✅​p
❌​ TestAccept/bundle/dms/existing-state ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/dms/existing-state/DMS= ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
🔄​ TestAccept/bundle/dms/no-drift ✅​p ✅​p ✅​p ✅​p 🔄​f ✅​p
🔄​ TestAccept/bundle/dms/no-drift/DMS=true ✅​p ✅​p ✅​p ✅​p 🔄​f ✅​p
❌​ TestAccept/bundle/dms/repeated-migration ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
❌​ TestAccept/bundle/dms/repeated-migration/DMS=true ❌​F ❌​F ❌​F ❌​F ❌​F ❌​F
🔄​ TestAccept/bundle/dms/stale-plan ✅​p ✅​p ✅​p ✅​p 🔄​f ✅​p
🔄​ TestAccept/bundle/dms/stale-plan/DMS=true/READPLAN=1 ✅​p ✅​p ✅​p ✅​p 🔄​f ✅​p
🔄​ TestAccept/bundle/dms/successful-recreate 🔄​f ✅​p ✅​p ✅​p ✅​p ✅​p
🔄​ TestAccept/bundle/dms/successful-recreate/DMS=true 🔄​f ✅​p ✅​p ✅​p ✅​p ✅​p
🔄​ TestSyncIncrementalFileOverwritesFolder 🔄​f ✅​p ✅​p ✅​p ✅​p ✅​p
🔄​ TestSyncIncrementalFileSync ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
Top 18 slowest tests (at least 2 minutes):
duration env testname
3:00 aws-windows-latest-4core-16gb TestAccept/bundle/dms/stale-plan/DMS=true/READPLAN=1
2:59 azure linux-2core-8gb TestAccept/bundle/dms/no-drift/DMS=true
2:56 gcp-windows-latest-4core-16gb TestAccept/bundle/dms/stale-local-state/DMS=
2:52 aws linux-2core-8gb TestAccept/bundle/dms/successful-recreate/DMS=true
2:30 aws linux-2core-8gb TestAccept/bundle/dms/stale-plan/DMS=true/READPLAN=1
2:30 aws linux-2core-8gb TestAccept/bundle/dms/stale-plan/DMS=true/READPLAN=
2:27 azure-windows-latest-4core-16gb TestAccept/bundle/dms/stale-plan/DMS=true/READPLAN=
2:24 gcp-windows-latest-4core-16gb TestImportDir
2:21 gcp-windows-latest-4core-16gb TestAccept/bundle/dms/stale-plan/DMS=true/READPLAN=1
2:19 azure-windows-latest-4core-16gb TestAccept/bundle/dms/multiple-resources/DMS=true
2:18 gcp linux-2core-8gb TestAccept/bundle/dms/declined-deploy/DMS=true
2:17 gcp-windows-latest-4core-16gb TestAccept/bundle/dms/declined-deploy/DMS=true
2:13 gcp linux-2core-8gb TestAccept/bundle/dms/successful-recreate/DMS=true
2:12 aws-windows-latest-4core-16gb TestFilerReadDir/workspace_files_extensions
2:09 aws linux-2core-8gb TestAccept/bundle/dms/no-drift/DMS=true
2:04 aws-windows-latest-4core-16gb TestAccept/bundle/dms/no-drift/DMS=true
2:03 azure linux-2core-8gb TestAccept/bundle/dms/stale-local-state/DMS=
2:00 azure-windows-latest-4core-16gb TestAccept/bundle/dms/stale-plan/DMS=true/READPLAN=1

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants