Repository navigation
Conversation
Contributor
|
Commit: Regression test reportSelected 4 changed tests (limit=20, 0 not selected) 7 tests: regression=7 unreleased=0 coverage=0 failing=0
TestAccept/bundle/lifecycle/depends-on-validation/DMS=: branch ✅ | main (b158966) ❌ | latest (v1.21.0) ❌main (b158966): latest (v1.21.0): TestAccept/bundle/lifecycle/depends-on-validation/DMS=true: branch ✅ | main (b158966) ❌ | latest (v1.21.0) ❌main (b158966): latest (v1.21.0): TestAccept/bundle/lifecycle/depends-on/DMS=: branch ✅ | main (b158966) ❌ | latest (v1.21.0) ❌main (b158966): latest (v1.21.0): TestAccept/bundle/lifecycle/depends-on/DMS=true: branch ✅ | main (b158966) ❌ | latest (v1.21.0) ❌main (b158966): latest (v1.21.0): TestAccept/bundle/migrate/auto/depends-on/DMS=: branch ✅ | main (b158966) ❌ | latest (v1.21.0) ❌main (b158966): latest (v1.21.0): TestAccept/bundle/refschema/DMS=: branch ✅ | main (b158966) ❌ | latest (v1.21.0) ❌main (b158966): latest (v1.21.0): TestAccept/bundle/refschema/DMS=true: branch ✅ | main (b158966) ❌ | latest (v1.21.0) ❌main (b158966): |
Collaborator
Integration test reportCommit: 9f38d4a
Top 3 slowest tests (at least 2 minutes):
|
denik
force-pushed
the
denik/depends-on
branch
2 times, most recently
from
October 20, 2026 13:07
25ceaa6 to
9124e27
Compare
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
…njected references Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
The injected ${resources.schemas.X.name} references also carry the deployed
name (e.g. the dev-mode prefix), so replacing them with depends_on breaks
dependents.
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/depends-on
branch
from
October 20, 2026 13:48
8ea9df4 to
0d4dd13
Compare
denik
added this pull request to stack #7131
October 20, 2026 13:48
Co-authored-by: Isaac <no-reply@databricks.com>
pietern
reviewed
Oct 21, 2026
| // DependsOn is a single lifecycle.depends_on entry. | ||
| type DependsOn struct { | ||
| // Key of the resource to depend on: "foo" or "jobs.foo". | ||
| Node string `json:"node"` |
Contributor
There was a problem hiding this comment.
Node is an internal name that isn't part of the configuration anywhere (yet).
I think "resource" fits better because it depends on a resource. If we later add dependencies on other things we can call them by their name too.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add
lifecycle.depends_on, a list of- node: <key>entries (fooorjobs.foo) that orders a resource after the listed ones on deploy and before them on destroy. Edges are saved in state like reference-derived ones, including bybundle migrate. A target that is skipped from the plan is ignored.Builds on #7128 (
Resources.ResolveKey). Used by #7132 to replace the references injected for implicit schema/catalog dependencies.Tests
Acceptance tests for ordering, validation errors, and a config with
depends_onmigrating from Terraform.This pull request and its description were written by Isaac.