Repository navigation
Run remote hosts on Windows over direct SSH - #1114
Merged
thesiti92 merged 2 commits intoOct 15, 2026
Merged
Conversation
thesiti92
had a problem deploying
to
review-release-approval
October 13, 2026 20:01 — with
GitHub Actions
Error
thesiti92
force-pushed
the
remote/16-windows-remote-hosts
branch
from
October 14, 2026 07:13
653cb8c to
aebb7da
Compare
thesiti92
force-pushed
the
remote/16-windows-remote-hosts
branch
from
October 14, 2026 14:14
aebb7da to
311b4f9
Compare
thesiti92
force-pushed
the
remote/16-windows-remote-hosts
branch
from
October 14, 2026 17:27
311b4f9 to
58399a9
Compare
3 tasks
thesiti92
force-pushed
the
remote/16-windows-remote-hosts
branch
2 times, most recently
from
October 14, 2026 17:51
0a25027 to
fe2abe0
Compare
thesiti92
force-pushed
the
remote/16-windows-remote-hosts
branch
from
October 14, 2026 18:21
fe2abe0 to
67c5b9a
Compare
thesiti92
force-pushed
the
remote/16-windows-remote-hosts
branch
2 times, most recently
from
October 14, 2026 19:29
598263e to
1632be4
Compare
thesiti92
force-pushed
the
remote/16-windows-remote-hosts
branch
from
October 14, 2026 19:36
1632be4 to
7a25377
Compare
thesiti92
force-pushed
the
remote/16-windows-remote-hosts
branch
2 times, most recently
from
October 14, 2026 19:44
4c492ba to
6194113
Compare
thesiti92
force-pushed
the
remote/16-windows-remote-hosts
branch
from
October 14, 2026 19:53
6194113 to
5d285da
Compare
thesiti92
force-pushed
the
remote/16-windows-remote-hosts
branch
2 times, most recently
from
October 14, 2026 20:06
216cb4c to
e218436
Compare
thesiti92
force-pushed
the
remote/16-windows-remote-hosts
branch
from
October 14, 2026 20:44
e218436 to
46b800e
Compare
thesiti92
force-pushed
the
remote/16-windows-remote-hosts
branch
2 times, most recently
from
October 15, 2026 00:40
a5ce4a8 to
73f7d3b
Compare
thesiti92
force-pushed
the
remote/16-windows-remote-hosts
branch
from
October 15, 2026 01:14
73f7d3b to
a9d26b0
Compare
thesiti92
added this pull request to stack #1148
October 15, 2026 01:14
thesiti92
marked this pull request as ready for review
October 15, 2026 01:14
sidkmenon
approved these changes
Oct 15, 2026
Windows laptops use the inbox Win32-OpenSSH with hidden, non-detached ssh processes and direct sessions, so they need a key ssh-agent can use and a host already in known_hosts. A refused key says so.
thesiti92
force-pushed
the
remote/16-windows-remote-hosts
branch
from
October 15, 2026 01:45
a9d26b0 to
9862ebc
Compare
thesiti92
added a commit
that referenced
this pull request
Oct 15, 2026
`copyText`, `CopyableText` and `CopyButton` move from `packages/review/app/src/copy-text.tsx` into the UI kit as `@canvas/ui/copy`, with one copy glyph instead of two. The kit stays free of app code: the components take their tooltip from a kit-owned host context (`ui/host.tsx`) whose default does nothing, and the app installs `UiHostProvider` with its `useTooltip` once at each root. Stacked on #1114. ## Test plan - [ ] Browser tests for the touched files and the review package tests. - [ ] Root typecheck and lint. - [ ] In Desktop: hover a hand-install hint in Settings shows "Click to copy", clicking copies it and shows "Copied"; the copy button on a prompt card still copies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns remote hosts back on for Windows laptops (reverting #1110's early return) with direct sessions from #1113.
%SystemRoot%\System32\OpenSSH\ssh.exeis used when present, ahead of an MSYS ssh (Git for Windows) on PATH.windowsHideand not detached; a detached ssh gets a console window on Windows.ssh-add; an unknown host key already says to runssh <alias>in a terminal.Includeglobs in ssh_config take forward slashes on Windows.Checked in a Windows 11 VM (24H2, ARM64, inbox OpenSSH 9.5p1) against a Linux container with the real modules and the Desktop's spawn options: picks the inbox ssh.exe; exec and the probe run with no prompt and no window;
uploadFileis byte-exact into a path with a space; the-Dmaster, a forward to the host's sshd and a held-Rround trip work; an unknown host key and an unauthorized key fail fast with ssh's own messages; anIncludewith a Windows path lists its aliases; no ssh.exe is left after. A dev build of this branch also ran in that VM (ARM64 Electron), against a Linux host with Whiteboard on its PATH, using an ssh-agent key: online in 10 s,/healththrough the SOCKS forward, a killed master recovered in under 2 s, and a normal quit left no ssh.exe. Dev-only gaps on Windows ARM64, unrelated to this change, kept it from the UI and the dev install:run.shlooks forreviewrather thanWhiteboard.exeand hands MSYS paths to node, the curated extensions anddiffrhave no win32-arm64 target, and the dev pack (pnpm pack) fails there.Stacked on #1113.