Refactor direct dependency surface#227
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduces Wayscriber’s direct dependency surface by replacing small direct dependencies with focused
local implementations and test helpers.
Direct external deps across the workspace go from 29 to 21.
Removed direct deps:
env_loggerasync-traitbase64signal-hookfutures-utiltempfileassert_cmdpredicatesNotable Changes
env_loggerwith a small local logger, including file logging andRUST_LOGfiltering.signal-hookusage with a local Unix signal bridge.StreamExt::nextequivalent for zbus stream polling.tempfile,assert_cmd, andpredicatesusage with local helpers and direct assertions.Signal Handling Notes
The new signal bridge preserves the important daemon behavior:
SA_RESTARTerrnoacross the signal handlerIt intentionally does not chain prior signal handlers; Wayscriber owns these daemon/overlay signals.