refactor(cmd): rename --skip-pro flag to --skip-platform with hidden alias by skevetter · Pull Request #1639 · devsy-org/devsy

skevetter · 2026-10-21T23:30:36Z

Summary

devsy workspace list flag renamed from --skip-pro to --skip-platform.
--skip-pro kept as a hidden alias bound to the same field and default.
Go constants: names.SkipPlatform (visible) and names.SkipProAlias (hidden). names.SkipPro removed; no callers remain.

Why

Flag wording should match the platform terminology. The hidden alias keeps existing scripts working. Unknown flags still error.

Validation

mkdir -p dist && go build ./...
GOOS=windows go vet ./cmd/workspace/... ./pkg/flags/... ./pkg/clihelp/...
mise run cli:format; mise run cli:lint:ci (0 issues)
go test ./pkg/flags/... ./pkg/clihelp/... passes; go test ./cmd/workspace/ passes with -skip TestDescribeCmd_Plain
TestDescribeCmd_Plain* hangs on pristine origin/main too (pre-existing, not touched here)
cd desktop && npx vitest run src/main/__tests__/cli.test.ts (36/36); npx biome check on the touched TS file
mise run cli:build:dev; workspace list --help shows only --skip-platform; --skip-platform and --skip-pro both exit 0; --skip-bogus errors UNKNOWN

CodeRabbit CLI

One minor finding: keep names.SkipPro as a deprecated alias. Not applied: no callers remain (go build ./... passes) and the repo policy is clean cutover, no shims.

Tier

T2: backward-compatible flag rename with hidden alias.

Auto-merge

Non-test changed lines: 19 (cmd/workspace/list.go 16, pkg/flags/names/names.go 3) in 2 files. Fixture mock-devsy.cjs adds 9 more. Within policy; not merged, draft only.

Remaining

skip-pro|SkipPro|skipPro|SKIP_PRO on touched paths: 14 before, 11 after (hidden alias plus its tests and the mock's compat check). desktop/src/main/watcher.ts:267 still passes --skip-pro; it is in open PR #1609, so it is excluded here. Switch it to --skip-platform after #1609 merges.

Summary by CodeRabbit

New Features
- The workspace list command now provides the --skip-platform option.
Changes
- The previous --skip-pro spelling remains available as a hidden alias for compatibility. The visible option in command help is now --skip-platform.

…alias

netlify · 2026-10-21T23:30:43Z

✅ Deploy Preview for devsydev canceled.

Name	Link
🔨 Latest commit	`3444cfe`
🔍 Latest deploy log	https://app.netlify.com/projects/devsydev/deploys/6ad94b1f840f01192d9dae01

coderabbitai · 2026-10-21T23:30:44Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 433f2c10-d0b1-4419-99ad-6aeccf6f0ba4

📥 Commits

Reviewing files that changed from the base of the PR and between 47a168d and 3444cfe.

📒 Files selected for processing: 7

cmd/workspace/list.go
cmd/workspace/list_test.go
desktop/e2e/fixtures/mock-devsy.cjs
desktop/src/main/__tests__/cli.test.ts
pkg/clihelp/help_test.go
pkg/flags/names/names.go
pkg/flags/names/names_test.go

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 0 remain after this review.

📝 Walkthrough

The workspace list command now exposes --skip-platform and accepts --skip-pro as a hidden alias. Both flags set the same field. Desktop CLI fixtures and tests use the new flag name.

Changes: Workspace list flag

Layer / File(s)	Summary
Flag contract and command `pkg/flags/names/names.go`, `pkg/flags/names/names_test.go`, `cmd/workspace/list.go`, `cmd/workspace/list_test.go`	The command binds visible `skip-platform` and hidden `skip-pro` flags to `SkipPlatform`. Tests cover the default, both flag names, visibility, and wire names.
CLI flag consumers `desktop/e2e/fixtures/mock-devsy.cjs`, `desktop/src/main/__tests__/cli.test.ts`, `pkg/clihelp/help_test.go`	The desktop mock recognizes `--skip-platform`. CLI forwarding and help tests expect the new flag name.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Possibly related issues

Issue 1551 tracks the repo-wide Pro-to-Platform rename and includes --skip-pro in its checklist. This change renames that flag while retaining it as an alias.

Merge Risk: ⚪ Minimal · up to 3444c

The flag rename retains the old CLI spelling as a hidden alias, and no actionable merge-blocking risk is established.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 7 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly and concisely describes the main change: renaming --skip-pro to --skip-platform while retaining a hidden alias.
Description check		The description explains the change, motivation, compatibility behavior, validation performed, known pre-existing test issue, and remaining follow-up. It does not reproduce every template section, but…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description explains the change, motivation, compatibility behavior, validation performed, known pre-existing test issue, and remaining follow-up. It does not reproduce every template section, but it provides the critical information needed for review.

✨ Finishing Touches

✨ Simplify code

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

netlify · 2026-10-21T23:30:49Z

✅ Deploy Preview for images-devsy-sh canceled.

Name	Link
🔨 Latest commit	`3444cfe`
🔍 Latest deploy log	https://app.netlify.com/projects/images-devsy-sh/deploys/6ad94b1f26c9d823e3d8c088

skevetter · 2026-10-22T00:35:53Z

@coderabbitai review

coderabbitai · 2026-10-22T00:35:59Z

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

mergify · 2026-10-22T00:36:23Z

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

skevetter · 2026-10-22T00:36:26Z

@coderabbitai review

coderabbitai · 2026-10-22T00:36:33Z

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

skevetter · 2026-10-22T00:36:43Z

@coderabbitai review

coderabbitai · 2026-10-22T00:36:50Z

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

skevetter · 2026-10-22T00:51:46Z

@coderabbitai review

coderabbitai · 2026-10-22T00:51:52Z

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

skevetter · 2026-10-22T01:06:49Z

@coderabbitai review

coderabbitai · 2026-10-22T01:06:56Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

refactor(cmd): rename --skip-pro flag to --skip-platform with hidden …

3444cfe

…alias

skevetter added the rename Loft/Pro rename label Oct 21, 2026

github-actions Bot added the size/m label Oct 21, 2026

skevetter marked this pull request as ready for review October 22, 2026 00:35

skevetter merged commit dbfc5ca into main Oct 22, 2026
116 checks passed

skevetter deleted the refactor/rename-skip-pro-flag branch October 22, 2026 01:23

This was referenced Oct 22, 2026

Rename tracker: Loft -> Devsy, Pro -> Platform #1551

Open

refactor(desktop): pass --skip-platform in workspace watcher #1691

Merged

Conversation

skevetter commented Oct 21, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Validation

CodeRabbit CLI

Tier

Auto-merge

Remaining

Summary by CodeRabbit

Uh oh!

netlify Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for devsydev canceled.

Uh oh!

coderabbitai Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for images-devsy-sh canceled.

Uh oh!

skevetter commented Oct 22, 2026

Uh oh!

coderabbitai Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skevetter commented Oct 22, 2026

Uh oh!

coderabbitai Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skevetter commented Oct 22, 2026

Uh oh!

coderabbitai Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skevetter commented Oct 22, 2026

Uh oh!

coderabbitai Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skevetter commented Oct 22, 2026

Uh oh!

coderabbitai Bot commented Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

skevetter commented Oct 21, 2026 •

edited by coderabbitai Bot

Loading

netlify Bot commented Oct 21, 2026 •

edited

Loading

coderabbitai Bot commented Oct 21, 2026 •

edited

Loading

netlify Bot commented Oct 21, 2026 •

edited

Loading

coderabbitai Bot commented Oct 22, 2026 •

edited

Loading

mergify Bot commented Oct 22, 2026 •

edited

Loading

coderabbitai Bot commented Oct 22, 2026 •

edited

Loading

coderabbitai Bot commented Oct 22, 2026 •

edited

Loading

coderabbitai Bot commented Oct 22, 2026 •

edited

Loading

coderabbitai Bot commented Oct 22, 2026 •

edited

Loading