Skip to content

chore: remove __all__#2536

Merged
paul-nechifor merged 2 commits into
mainfrom
paul/chore/remove-all
Jun 21, 2026
Merged

chore: remove __all__#2536
paul-nechifor merged 2 commits into
mainfrom
paul/chore/remove-all

Conversation

@paul-nechifor

Copy link
Copy Markdown
Contributor

Problem

Constantly updating __all__ = [...] is tedious. They are only needed for from x import * which we don't use.

Closes DIM-1024

Solution

  • Remove all __all__ declarations.
  • Add a test to prevent them being added again.

@greptile-apps

greptile-apps Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Too many files changed for review. (130 files found, 100 file limit)

@paul-nechifor paul-nechifor force-pushed the paul/chore/remove-all branch from 347ad98 to 283857f Compare June 19, 2026 22:48
@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.78788% with 7 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
dimos/codebase_checks/test_no_all.py 80.76% 3 Missing and 2 partials ⚠️
dimos/hardware/sensors/camera/zed/compat.py 0.00% 1 Missing ⚠️
dimos/robot/cli/topic.py 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main    #2536      +/-   ##
==========================================
- Coverage   70.89%   70.85%   -0.04%     
==========================================
  Files         851      852       +1     
  Lines       77198    77118      -80     
  Branches     6850     6855       +5     
==========================================
- Hits        54730    54645      -85     
- Misses      20666    20669       +3     
- Partials     1802     1804       +2     
Flag Coverage Δ
OS-ubuntu-24.04-arm 62.94% <78.12%> (-0.04%) ⬇️
OS-ubuntu-latest 65.77% <78.78%> (-0.04%) ⬇️
Py-3.10 65.77% <78.78%> (-0.03%) ⬇️
Py-3.11 65.77% <78.78%> (-0.03%) ⬇️
Py-3.12 65.77% <78.78%> (-0.03%) ⬇️
Py-3.13 65.77% <78.78%> (-0.04%) ⬇️
Py-3.14 65.78% <78.78%> (-0.04%) ⬇️
Py-3.14t 65.77% <78.78%> (-0.04%) ⬇️
SelfHosted-Large 30.09% <36.36%> (-0.05%) ⬇️
SelfHosted-Linux 37.72% <33.33%> (-0.05%) ⬇️
SelfHosted-macOS 36.50% <36.36%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dimos/codebase_checks/test_get_logger.py 72.34% <ø> (ø)
dimos/codebase_checks/test_no_init_files.py 62.50% <ø> (ø)
dimos/codebase_checks/test_no_sections.py 71.66% <ø> (ø)
dimos/control/blueprints/_hardware.py 66.00% <ø> (-0.67%) ⬇️
dimos/control/blueprints/basic.py 90.00% <ø> (-0.48%) ⬇️
dimos/control/blueprints/dual.py 100.00% <ø> (ø)
dimos/control/blueprints/mobile.py 100.00% <ø> (ø)
dimos/control/blueprints/teleop.py 93.10% <ø> (-0.23%) ⬇️
dimos/control/components.py 88.46% <ø> (-0.22%) ⬇️
dimos/control/hardware_interface.py 50.00% <ø> (-0.28%) ⬇️
... and 99 more

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

leshy
leshy previously approved these changes Jun 20, 2026
leshy
leshy previously approved these changes Jun 20, 2026
@paul-nechifor paul-nechifor force-pushed the paul/chore/remove-all branch from 6667d57 to 277fe06 Compare June 21, 2026 00:00
@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Jun 21, 2026
@github-actions github-actions Bot removed the ready-to-merge Required CI checks have passed on this PR label Jun 21, 2026
@paul-nechifor paul-nechifor merged commit 15e0810 into main Jun 21, 2026
27 checks passed
@paul-nechifor paul-nechifor deleted the paul/chore/remove-all branch June 21, 2026 01:20
@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Required CI checks have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants