[fix-finder] Enable nullable annotations for GetGdbSymbols - #12398
Merged
jonathanpeppers merged 1 commit intoAug 15, 2026
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
requested review from
jonathanpeppers and
simonrozsival
as code owners
August 15, 2026 02:13
jonathanpeppers
approved these changes
Aug 15, 2026
jonathanpeppers
deleted the
nightly/nrt-get-gdb-symbols-d3728f645336bcb0
branch
August 15, 2026 14:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GetGdbSymbolswas not opted into nullable reference type analysis. Its optionalAdbTargetproperty and required MSBuild task properties therefore lacked compiler-checked nullability contracts.Fix
Enabled nullable analysis in
GetGdbSymbols.cs, markedAdbTargetnullable, initialized all[Required]string properties to non-null defaults, and removed the now-redundant constructor assignment.Validation
MSBUILD_ARGS='/p:AndroidSdkDirectory=/home/runner/android-toolchain/sdk /p:AndroidNdkDirectory=/home/runner/android-toolchain/ndk' ./build.sh Prepare— passed./dotnet-local.sh build src/Xamarin.Android.Build.Debugging.Tasks/Xamarin.Android.Build.Debugging.Tasks.csproj -p:AndroidSdkDirectory=/home/runner/android-toolchain/sdk -p:AndroidNdkDirectory=/home/runner/android-toolchain/ndk -p:_AndroidTreatWarningsAsErrors=true --no-restore— passed with 0 warnings and 0 errorsFix-finder metadata
01-nullable-reference-types27/30(actionability:9, safety:9, scope:9)Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
southcentralus0.in.applicationinsights.azure.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.