Skip to content

[fix-finder] Enable nullable annotations for GetGdbSymbols - #12398

Merged
jonathanpeppers merged 1 commit into
mainfrom
nightly/nrt-get-gdb-symbols-d3728f645336bcb0
Aug 15, 2026
Merged

[fix-finder] Enable nullable annotations for GetGdbSymbols#12398
jonathanpeppers merged 1 commit into
mainfrom
nightly/nrt-get-gdb-symbols-d3728f645336bcb0

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

AI-generated fix. Produced by the nightly-fix-finder agentic workflow.

Problem

GetGdbSymbols was not opted into nullable reference type analysis. Its optional AdbTarget property and required MSBuild task properties therefore lacked compiler-checked nullability contracts.

Fix

Enabled nullable analysis in GetGdbSymbols.cs, marked AdbTarget nullable, initialized all [Required] string properties to non-null defaults, and removed the now-redundant constructor assignment.

Validation

  • MSBUILD_ARGS='/p:AndroidSdkDirectory=/home/runner/android-toolchain/sdk /p:AndroidNdkDirectory=/home/runner/android-toolchain/ndk' ./build.sh Prepare — passed
  • ./dotnet-local.sh build src/Xamarin.Android.Build.Debugging.Tasks/Xamarin.Android.Build.Debugging.Tasks.csproj -p:AndroidSdkDirectory=/home/runner/android-toolchain/sdk -p:AndroidNdkDirectory=/home/runner/android-toolchain/ndk -p:_AndroidTreatWarningsAsErrors=true --no-restore — passed with 0 warnings and 0 errors

Fix-finder metadata

  • Script: 01-nullable-reference-types
  • Score: 27/30 (actionability: 9, safety: 9, scope: 9)

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

  • southcentralus0.in.applicationinsights.azure.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "southcentralus0.in.applicationinsights.azure.com"

See Network Configuration for more information.

Generated by Nightly Fix Finder · gpt56 · 107.4 AIC · ⌖ 36.6 AIC · ⊞ 23.7K ·

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@jonathanpeppers
jonathanpeppers merged commit 06f6fb4 into main Aug 15, 2026
44 checks passed
@jonathanpeppers
jonathanpeppers deleted the nightly/nrt-get-gdb-symbols-d3728f645336bcb0 branch August 15, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant