Skip to content

[fix-finder] Enable nullable annotations for GetGdbSymbols #12398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 1 commit into from
Aug 15, 2026
+7 −12
Merged

[fix-finder] Enable nullable annotations for GetGdbSymbols #12398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions src/Xamarin.Android.Build.Debugging.Tasks/Tasks/GetGdbSymbols.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
#nullable enable
using System;
using System.IO;
using System.Linq;
using System.Threading;
Expand All @@ -15,24 +16,19 @@ public class GetGdbSymbols : AndroidTask
{
public override string TaskPrefix => "GGDB";

public string AdbTarget { get; set; }
public string? AdbTarget { get; set; }

[Required]
public string GdbSymbolsPath { get; set;}
public string GdbSymbolsPath { get; set; } = "";

[Required]
public string Package { get; set; }
public string Package { get; set; } = "";

[Required]
public string OutputPath { get; set; }
public string OutputPath { get; set; } = "";

[Required]
public string PrimaryCpuAbi {get; set; }

public GetGdbSymbols ()
{
AdbTarget = null;
}
public string PrimaryCpuAbi { get; set; } = "";

public override bool RunTask ()
{
Expand Down Expand Up @@ -63,4 +59,3 @@ void ExtractFilesFromPath(string apk, string path)
}
}
}