Skip to content

fix: ask to confirm a Memory change review with its details - #2120

Merged
Douglasymlai merged 1 commit into
mainfrom
fix/memory-review-card
Oct 27, 2026
Merged

Douglasymlai merged 1 commit into
mainfrom
fix/memory-review-card

Conversation

@Douglasymlai

Copy link
Copy Markdown
Contributor

Pull Request

Related Issue

N/A — maintainer-directed repair; no linked issue required for this PR.

Stacked on #2119 (base fix/question-after-reload), which is stacked on #2110. Retarget to main after those merge.

Description

Problem

When the agent asked to change a Memory, the request above the composer looked like an ordinary question with a text box. It did not show what would change (before and after), and a typed answer cannot approve or reject the change. The work log also showed an empty "Input required" card with Reject and Confirm, and after a window reload that empty card stayed next to the real review.

Cause

The default chat view offered every request that is not an approval as a free-text question. The work log drew its own card for the same request, without the change details, in addition to the control that actually decides it.

Fix

  • A Memory change review is shown above the composer as Confirm / Reject, with its before/after details. The decision is saved through the same path as the review card.
  • Typing in the composer while a review is open no longer sends the text as an answer.
  • The work log no longer adds a second, empty card for a pending review, so a reloaded Session shows one review with its details.
  • Questions and approvals are unchanged.

Testing Evidence (REQUIRED)

Automated checks (no manual app testing yet):

  • Live Memory change review: before, a text box without details; after, Confirm / Reject with the before/after details, and Confirm saves the decision.
  • Pending review in the work log: before, an empty Reject / Confirm card; after, none.
  • Questions and approvals still use their own controls.
  • Chat, store and lib unit suites pass apart from installation-store, theme and user-menu tests that fail the same way without this change. Type-check, ESLint, Prettier, the design-token check and the translation checks pass.

How to test manually (Memory on):

  1. In a Session, save a fact, confirm it in Memory settings, then ask the agent in the same Session to update it.
  2. The review above the composer shows Confirm / Reject and the before/after details; there is no text box.
  3. Expand the work log: no empty review card.
  4. Reload the window (Cmd+R): one review with its details; Confirm or Reject completes it.
  • I have included human-verified testing evidence in this PR.
  • This PR includes frontend/UI changes, and I attached screenshot(s) or screen recording(s).
  • No frontend/UI changes in this PR.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Contribution Guidelines Acknowledgement

@Douglasymlai
Douglasymlai marked this pull request as ready for review October 27, 2026 16:55
@Douglasymlai
Douglasymlai force-pushed the fix/question-after-reload branch from 74391d3 to 740fea3 Compare October 27, 2026 16:59
@Douglasymlai
Douglasymlai force-pushed the fix/memory-review-card branch from c8f49ce to 139fd0d Compare October 27, 2026 16:59
@Douglasymlai
Douglasymlai force-pushed the fix/question-after-reload branch from 740fea3 to 6b65aa7 Compare October 27, 2026 17:00
@Douglasymlai
Douglasymlai force-pushed the fix/memory-review-card branch from 139fd0d to 17b9da5 Compare October 27, 2026 17:00
@Douglasymlai
Douglasymlai changed the base branch from fix/question-after-reload to main October 27, 2026 17:13
@Douglasymlai
Douglasymlai force-pushed the fix/memory-review-card branch from 17b9da5 to b8813c5 Compare October 27, 2026 17:13
@Douglasymlai
Douglasymlai merged commit 5aa1c64 into main Oct 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant