Repository navigation
fix: ask to confirm a Memory change review with its details - #2120
Merged
Merged
Conversation
2 of 8 tasks
Douglasymlai
marked this pull request as ready for review
October 27, 2026 16:55
Douglasymlai
force-pushed
the
fix/question-after-reload
branch
from
October 27, 2026 16:59
74391d3 to
740fea3
Compare
Douglasymlai
force-pushed
the
fix/memory-review-card
branch
from
October 27, 2026 16:59
c8f49ce to
139fd0d
Compare
Douglasymlai
force-pushed
the
fix/question-after-reload
branch
from
October 27, 2026 17:00
740fea3 to
6b65aa7
Compare
Douglasymlai
force-pushed
the
fix/memory-review-card
branch
from
October 27, 2026 17:00
139fd0d to
17b9da5
Compare
Douglasymlai
force-pushed
the
fix/memory-review-card
branch
from
October 27, 2026 17:13
17b9da5 to
b8813c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Issue
N/A — maintainer-directed repair; no linked issue required for this PR.
Stacked on #2119 (base
fix/question-after-reload), which is stacked on #2110. Retarget tomainafter those merge.Description
Problem
When the agent asked to change a Memory, the request above the composer looked like an ordinary question with a text box. It did not show what would change (before and after), and a typed answer cannot approve or reject the change. The work log also showed an empty "Input required" card with Reject and Confirm, and after a window reload that empty card stayed next to the real review.
Cause
The default chat view offered every request that is not an approval as a free-text question. The work log drew its own card for the same request, without the change details, in addition to the control that actually decides it.
Fix
Testing Evidence (REQUIRED)
Automated checks (no manual app testing yet):
How to test manually (Memory on):
What is the purpose of this pull request?
Contribution Guidelines Acknowledgement