Repository navigation
fix: keep the agent's question and the user's answer in the chat - #2110
Merged
Merged
Conversation
Douglasymlai
marked this pull request as ready for review
October 25, 2026 17:40
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Issue
N/A — maintainer-directed repair; no linked issue required for this PR.
Follow-ups stacked on this PR: #2119 (answer a question still waiting after a reload) and #2120 (Memory change review controls).
Description
Problem
When the agent asked the user a question (for example "What is your favourite colour?") and the user answered, the question and the answer both disappeared once the task finished, including from the expanded work log. After reopening the Session, the answer came back as a separate turn without its question, a wrong "This task ended before Eigent sent a final reply." notice appeared above it, and "Worked for" changed.
Cause
Fix
Testing Evidence (REQUIRED)
App check in the development Electron build (agent-driven, real model, not yet human-verified):
teal), task finishes: one question + answer entry in the expanded run, final reply shown, no notice, file written. Same after switching Sessions, reloading the window and restarting the app.green: only the answered question shows, no empty entry for the cancelled one, across switch / reload / restart.Automated checks:
How to test manually:
use the ask-human tool to ask me my favourite colour, write it to colour.txt, then reply done. Answerteal.What is the purpose of this pull request?
Contribution Guidelines Acknowledgement