Skip to content

fix: let a question still waiting after a reload be answered - #2119

Merged
Douglasymlai merged 1 commit into
mainfrom
fix/question-after-reload
Oct 27, 2026
Merged

Douglasymlai merged 1 commit into
mainfrom
fix/question-after-reload

Conversation

@Douglasymlai

Copy link
Copy Markdown
Contributor

Pull Request

Related Issue

N/A — maintainer-directed repair; no linked issue required for this PR.

Stacked on #2110 (base fix/ask-reply-in-chat). Retarget to main after #2110 merges.

Description

Problem

When the agent was waiting for an answer to its question and the user reloaded the window, the question could no longer be answered. The answer box above the composer disappeared, the chat showed the question without any way to reply, and the task kept waiting forever.

Cause

After a reload the Session's task is restored for playback. The answer box above the composer was only offered for live tasks, so a restored task never got one, even though its Run was still waiting for the answer. The card shown in the chat instead has no answer field for questions.

Fix

  • When a restored task's Run is still waiting for a question, the question is offered above the composer and answered exactly as when live.
  • The chat no longer also shows that question as a card that cannot be answered.
  • Approvals and other requests after a reload are unchanged.

Testing Evidence (REQUIRED)

Automated checks (no manual app testing yet):

  • Reopened Session with a question still waiting: before, no answer box; after, the question is offered above the composer and the answer is sent to the waiting task.
  • Reopened Session whose Run already finished: no answer box is offered.
  • The chat shows no extra question card while the question waits.
  • Chat, store and lib unit suites pass apart from installation-store, theme and user-menu tests that fail the same way without this change. Type-check, ESLint, Prettier and the design-token check pass.

How to test manually:

  1. Send: use the ask-human tool to ask me my favourite colour, write it to colour3.txt, then reply done. Don't answer.
  2. Reload the window (Cmd+R). The question is still above the composer and can be answered.
  3. Answer red: the task continues and writes the file.
  • I have included human-verified testing evidence in this PR.
  • This PR includes frontend/UI changes, and I attached screenshot(s) or screen recording(s).
  • No frontend/UI changes in this PR.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Contribution Guidelines Acknowledgement

@Douglasymlai
Douglasymlai marked this pull request as ready for review October 27, 2026 16:55
@Douglasymlai
Douglasymlai force-pushed the fix/question-after-reload branch from 74391d3 to 740fea3 Compare October 27, 2026 16:59
@Douglasymlai
Douglasymlai changed the base branch from fix/ask-reply-in-chat to main October 27, 2026 16:59
@Douglasymlai
Douglasymlai force-pushed the fix/question-after-reload branch from 740fea3 to 6b65aa7 Compare October 27, 2026 17:00
@Douglasymlai
Douglasymlai merged commit 42a6e2c into main Oct 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant