chore: harden addon warning logging and empty drain - #8869
Open
atharvaHJoshi wants to merge 1 commit into
Open
atharvaHJoshi wants to merge 1 commit into
atharvaHJoshi wants to merge 1 commit into
Conversation
Signed-off-by: Atharva Joshi <josh.atharva2005@gmail.com>
Contributor
|
Hello atharvaHJoshi 👋 Thank you for opening a Pull Request in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Two small hardening fixes found during issue investigations:
pkg/actions/addon/create.go—logger.Warningused the%wverb (intended forfmt.Errorf/error wrapping). Loggers that follow thego-kitconvention render%was a literal%!w(...)placeholder, so the actual error text was garbled.Switched to
%v.pkg/actions/nodegroup/drain.go—Drainer.Drainnow returns early when it isasked to drain zero nodegroups, instead of logging "starting parallel draining"
and clearing with nothing to do.
Validation
go build ./...golangci-lint run --timeout=30m ./pkg/...go test ./pkg/actions/...Pre-existing, unrelated failures in
pkg/infoandpkg/iam/oidcare environmental(kubectl/
cfsslmissing locally) and remain unchanged.