Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/actions/addon/create.go
Original file line number Diff line number Diff line change
Expand Up @@ -267,11 +267,11 @@ func (a *Manager) Create(ctx context.Context, addon *api.Addon, iamRoleCreator I
defer func() {
deleteAddonIAMTasks, err := NewRemover(a.stackManager).DeleteAddonIAMTasksFiltered(ctx, addon.Name, false)
if err != nil {
logger.Warning("failed to cleanup IAM role stacks: %w; please remove any remaining stacks manually", err)
logger.Warning("failed to cleanup IAM role stacks: %v; please remove any remaining stacks manually", err)
return
}
if err := runAllTasks(deleteAddonIAMTasks); err != nil {
logger.Warning("failed to cleanup IAM role stacks: %w; please remove any remaining stacks manually", err)
logger.Warning("failed to cleanup IAM role stacks: %v; please remove any remaining stacks manually", err)
}
}()
var addonServiceAccounts []string
Expand Down
3 changes: 3 additions & 0 deletions pkg/actions/nodegroup/drain.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ type Drainer struct {

// Drain drains nodegroups.
func (d *Drainer) Drain(ctx context.Context, input *DrainInput) error {
if len(input.NodeGroups) == 0 {
return nil
}
parallelLimit := int64(input.Parallel)
sem := semaphore.NewWeighted(parallelLimit)
logger.Info("starting parallel draining, max in-flight of %d", parallelLimit)
Expand Down
Loading