Repository navigation
fix(build): inherit NumericalToolbox_ENABLE_OPTIMIZATIONS from numerical.math - #21
Merged
Merged
Conversation
…cal.math The define was set with directory-scoped add_definitions, so it never reached the translation units of projects consuming this library and OPTIMIZE_FOR_SPEED silently expanded to nothing there. numerical-toolbox now attaches it as a usage requirement of numerical.math (embedded-pro/numerical-toolbox-cpp#346): bump the pin to include that change, forward ROBOTICS_TOOLBOX_ENABLE_OPTIMIZATIONS to NUMERICAL_TOOLBOX_ENABLE_OPTIMIZATIONS, and drop the add_definitions. Mirrors embedded-pro/numerical-toolbox-cpp#337. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N4pngRiBqeb1xiseKXNLG6
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Max errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 7 | 0 | 0 | 0.48s | ||
| ✅ CPP | clang-format | 35 | 0 | 0 | 0 | 0.65s | |
| ✅ CPP | cppcheck | 35 | 0 | 0 | 0.84s | ||
| ✅ DOCKERFILE | hadolint | 1 | 0 | 0 | 0.31s | ||
| ✅ JSON | jsonlint | 8 | 0 | 0 | 0.08s | ||
| ✅ JSON | prettier | 8 | 2 | 0 | 0 | 0.3s | |
| ✅ MARKDOWN | markdownlint | 131 | 0 | 0 | 0 | 1.56s | |
| ✅ MARKDOWN | markdown-table-formatter | 131 | 0 | 0 | 0 | 0.16s | |
| lychee | 165 | 2 | 0 | 1.25s | |||
| ✅ YAML | prettier | 12 | 0 | 0 | 0 | 0.45s | |
| ✅ YAML | yamllint | 12 | 0 | 0 | 0.48s |
Detailed Issues
⚠️ SPELL / lychee - 2 errors
[ERROR] failed to verify TLS certificate: invalid peer certificate: UnknownIssuer
📝 Summary
---------------------
🔍 Total..........104
🔗 Unique..........42
✅ Successful......92
⏳ Timeouts.........0
🔀 Redirected.......5
👻 Excluded.........9
❓ Unknown..........0
🚫 Errors...........2
⛔ Unsupported......2
Errors in .github/workflows/static-analysis.yml
[403] https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-$ (at 37:21) | Rejected status code: 403 Forbidden
Errors in doc/kinematics/InverseKinematics.md
[ERROR] https://mathweb.ucsd.edu/~sbuss/ResearchWeb/ikmethods/iksurvey.pdf (at 124:169) | SSL certificate not trusted. Use --insecure if site is trusted
Hint: Followed 5 redirects. You might want to consider replacing redirecting URLs with the resolved URLs. Use verbose mode (`-v`/`-vv`) to see redirection details.
Hint: You can configure accepted/rejected response codes with `-a` or `--accept`
Notices
REPOSITORY_GITLEAKS, REPOSITORY_KICS. See Removed linters to find their replacements.
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx mega-linter-runner@10.1.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,CPP_CPPCHECK,CPP_CLANG_FORMAT,DOCKERFILE_HADOLINT,JSON_JSONLINT,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT

Show us your support by starring ⭐ the repository
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Mirrors embedded-pro/numerical-toolbox-cpp#346 (issue embedded-pro/numerical-toolbox-cpp#337).
Problem.
add_definitions(-DNumericalToolbox_ENABLE_OPTIMIZATIONS=1)is directory-scoped. When this repo is consumed viaFetchContent, the define never reaches the consumer's translation units, soOPTIMIZE_FOR_SPEEDin the robotics headers silently expands to nothing.Change
1225b3c→69ff13e(currentmain). There,numerical.mathcarriesNumericalToolbox_ENABLE_OPTIMIZATIONSas a usage requirement, so every target linkingnumerical.*inherits it, including downstream consumers of this repo.ROBOTICS_TOOLBOX_ENABLE_OPTIMIZATIONStoNUMERICAL_TOOLBOX_ENABLE_OPTIMIZATIONSbefore fetching numerical-toolbox. This keeps the existing option, and the coverage preset that turns itOff, working.add_definitions.What the bump also brings in from numerical-toolbox:
O3/fast-mathpragma is scoped per header instead of leaking into including TUs.Validation (host, GCC 13, Debug,
-Werror)compile_commands.json: 6/6 repo TUs get-DNumericalToolbox_ENABLE_OPTIMIZATIONS=1, and 0/6 with-DROBOTICS_TOOLBOX_ENABLE_OPTIMIZATIONS=Off.🤖 Generated with Claude Code
https://claude.ai/code/session_01N4pngRiBqeb1xiseKXNLG6
Generated by Claude Code