Repository navigation
feat(specs,tests): reject an occupied EIP-8250 nonce manager address at the fork block - #3725
Closed
spencer-tb wants to merge 5 commits into
Closed
spencer-tb wants to merge 5 commits into
spencer-tb wants to merge 5 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/bogota/eip-8250 #3725 +/- ##
=======================================================
Coverage ? 94.94%
=======================================================
Files ? 677
Lines ? 41934
Branches ? 3964
=======================================================
Hits ? 39813
Misses ? 1467
Partials ? 654
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Oct 6, 2026
…n schedule Co-authored-by: Jochem Brouwer <29359032+jochem-brouwer@users.noreply.github.com>
…ock's access list
…l in the fork block
…ress at the fork block
…once manager address
spencer-tb
force-pushed
the
eip-8250-occupied-address
branch
from
October 6, 2026 17:01
9669e0e to
2c8b13b
Compare
This was referenced Oct 6, 2026
gurukamath
added a commit
to gurukamath/execution-specs
that referenced
this pull request
Oct 7, 2026
Review follow-up for ethereum#3729. EIP-8250 installs its nonce manager through `activation_code_installs` on `eips/bogota/eip-8250`, and ethereum#3722 and ethereum#3725 build on it, so removing the hook here would break that install when the branches merge. Restore the hook, Frontier's empty implementation, both blockchain filler call sites, the Hive genesis builder, the pre-allocation group builder, and `Alloc.with_installed_code`, all as they are on the base branch. Only the EIP-8141 override stays removed: the expiry verifier is a predeploy, not an activation install. The `with_installed_code` docstring no longer names an EIP as its example. Reword the `EXPIRY_VERIFIER` docstring and the fork transition test module docstring as suggested in review.
This was referenced Oct 7, 2026
Contributor
Author
|
Superseded by #3736. |
Merged
5 of 16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merge order: after #3557, #3722 and ethereum/EIPs#12440, which itself follows ethereum/EIPs#12406.
Implements ethereum/EIPs#12440 for EIP-8250: code or storage at
NONCE_MANAGERin the fork block's parent state makes that block invalid, checked before the install writes anything. AddsPreState.account_has_storageso the spec can query storage emptiness, andBlockException.SYSTEM_CONTRACT_ADDRESS_OCCUPIEDfor the fixtures.Stacked on #3722, only the last two commits belong to this PR.
Related Issues or PRs
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture