[spencer-tb]

Description

Review follow-up to #3756.

• keyed_nonce_access_cost is read off Op.SSTORE(key_warm=False, original_value=1, new_value=2) instead of a hardcoded 2_100 + 10_000, so EIP-8038 repricings flow through as the EIP defines the cost.
• Drops the asserts comparing the test's sum against the framework calculators. The receipt check against the spec already covers it.
• Adds test_gas_limit_cap_counts_keyed_nonce_access: the maximum key set with frame gas landing on the per-transaction gas cap or one above. A client that charges the access cost at nonce consumption instead of in intrinsic gas gets gas used right but misses the cap. A second anchor sizes frame data so the calldata floor lands on the cap or one byte above, since the cap checks the larger of the two.
• Adds test_payer_max_cost_counts_keyed_nonce_access: the maximum key set's payer funded with exactly the max cost or one wei less, so the access cost must be in the escrow APPROVE checks.

Without the spec's access cost the above_cap fixtures fail, along with the 24 keyed test_keyed_nonce_access_cost cases. Dropping it from the floor alone fails only above_cap-floor, and from the max cost alone only one_wei_short.

Related Issues or PRs

• feat(spec-specs,test-forks,tests): charge EIP-8250 keyed nonce access in intrinsic gas and the calldata floor #3756
• Test Release Tracker: bogota-devnet@v1.1.0 #3773

Checklist

• Ran fast static checks to avoid CI fails, see Code Standards & Verifying Changes: just static
• PR title has the form <type>(<area>): <title>, where <type> and <area> come from an appropriate C-<type>, respectively A-<area>, label. The title should match the target squash commit message.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (eips/bogota/eip-8250@539fa84). Learn more about missing BASE report.

Additional details and impacted files

@@                   Coverage Diff                   @@
##             eips/bogota/eip-8250    #3775   +/-   ##
=======================================================
  Coverage                        ?   95.01%           
=======================================================
  Files                           ?      678           
  Lines                           ?    41930           
  Branches                        ?     3933           
=======================================================
  Hits                            ?    39841           
  Misses                          ?     1453           
  Partials                        ?      636           

Flag	Coverage Δ
unittests	95.01% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.