feat(docs): add settings.embedding.allowed-origins to docs.yml - #17773
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…blank lines Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Devin Review found 1 potential issue.
2 flags not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
…ed CSP sources Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Docs Generation Benchmark ResultsComparing PR branch against median of 5 nightly run(s) on
Docs generation runs |
SDK Generation Benchmark ResultsComparing PR branch against median of 5 nightly run(s) on Full benchmark table (click to expand)
main (generator): generator-only time via --skip-scripts (includes Docker image build, container startup, IR parsing, and code generation — this is the same Docker-based flow customers use via |
ReviewOverview. Additive plumbing of Notes (non-blocking):
Merge order is CLI PR → CLI release → platform PR, as the platform PR notes. |
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Description
Linear ticket: Refs
Adds
settings.embedding.allowed-originstodocs.ymlso customers can whitelist third-party origins that may embed their docs site in an iframe. The CLI passes the list through to FDR asdocsConfig.embedding.allowedOrigins; the platform appends each origin to theframe-ancestorsCSP directive (platform-side change is separate).Changes Made
fern/apis/docs-yml/definition/docs.yml+ regenerateddocs-yml.schema.json(root andworkspace/loader): newEmbeddingConfig { allowed-origins: list<string> }, exposed asDocsSettingsConfig.embedding@fern-api/configuration: zodEmbeddingConfigschema, generated SDK api/serialization types,ParsedDocsSettingsConfig.embedding@fern-api/configuration-loader:convertSettingsConfigpassessettings.embeddingthrough@fern-api/docs-resolver:DocsDefinitionResolveremitsembedding: { allowedOrigins }on the writtenDocsConfig(typed via the existing local shim until@fern-api/fdr-sdkpublishes the field)remote-workspace-runner/mapDocsConfigToLedgerConfig: forwardsembeddinginto the ledger config (same shim)packages/cli/cli/changes/unreleased/add-docs-embedding-allowed-origins.ymlTesting
configuration-loader/src/docs-yml/__test__/embeddingAllowedOrigins.test.ts(omitted → undefined, passthrough toallowedOrigins, missingallowed-originsrejected); 3/3 passpnpm turbo run compilefor configuration-loader, docs-resolver, remote-workspace-runner, docs-validator passesLink to Devin session: https://app.devin.ai/sessions/5852f54aac7e4702ba83e25ad2baec01
Open in Devin Desktop: https://app.devin.ai/desktop/session/5852f54aac7e4702ba83e25ad2baec01?variant=devin
Requested by: @willkendall01