test(smoke): make the /api/icon smoke test actually run against production - #298
Merged
Merged
Conversation
…ction The test added in #297 failed on its first live run for two reasons that the unit run could not show: example.com has no favicon (its ?domain= answer is an empty text/plain 200 and its /favicon.ico a 404), and the default happy-dom environment blocks the cross-origin fetch outright. Fixtures are now our own domain and the file runs under node like every other smoke test. Verified green against my.feedzero.app before commit. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GQoLHbPfaTCHvPuaoqGZeJ
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
forcingfx
enabled auto-merge (squash)
September 9, 2026 20:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #297. Its smoke test failed on first live run: example.com has no favicon (empty text/plain 200 for
?domain=, 404 for/favicon.ico), and the default happy-dom environment blocks the cross-origin fetch. Fixtures are nowfeedzero.app, and the file runs under// @vitest-environment nodelike the other smoke tests.Verified green against production before commit:
🤖 Generated with Claude Code
https://claude.ai/code/session_01GQoLHbPfaTCHvPuaoqGZeJ