Skip to content

test(smoke): make the /api/icon smoke test actually run against production #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forcingfx merged 2 commits into from
Sep 9, 2026
+10 −7
Merged

test(smoke): make the /api/icon smoke test actually run against production #298

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6541b89
test(smoke): make the /api/icon smoke test actually run against produ…
forcingfx Sep 9, 2026
6dbcc3e
Merge branch 'main' into test/icon-smoke-fixture
forcingfx Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions tests/smoke/icon.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// @vitest-environment node
import { describe, it, expect } from "vitest";

/**
Expand All @@ -14,20 +15,22 @@ const BASE = process.env.SMOKE_BASE_URL ?? "https://my.feedzero.app";
const enabled = process.env.SMOKE_TESTS === "1";

describe.skipIf(!enabled)("smoke: /api/icon", () => {
// Fixtures are our own domain: example.com has no favicon at all (its
// ?domain= answer is an empty text/plain 200, its /favicon.ico a 404),
// which is exactly the "mock encodes a belief about the service" trap
// CLAUDE.md's Tier 2.5 rule warns about. Verified with curl before use.
it("serves a favicon for ?domain= with a cacheable image response", async () => {
const res = await fetch(`${BASE}/api/icon?domain=example.com`);
const res = await fetch(`${BASE}/api/icon?domain=feedzero.app`);
expect(res.status).toBe(200);
expect(res.headers.get("content-type")).toMatch(/^image\//);
expect(res.headers.get("cache-control")).toMatch(/max-age=86400/);
});

it("proxies an explicit image url", async () => {
it("proxies an explicit image url as an image", async () => {
const res = await fetch(
`${BASE}/api/icon?url=${encodeURIComponent("https://example.com/favicon.ico")}`,
`${BASE}/api/icon?url=${encodeURIComponent("https://feedzero.app/favicon.ico")}`,
);
// example.com has no favicon; the contract is that the proxy answers
// for the URL rather than rejecting the shape.
expect([200, 404, 502]).toContain(res.status);
expect(res.status).not.toBe(400);
expect(res.status).toBe(200);
expect(res.headers.get("content-type")).toMatch(/^image\//);
});
});