fix(validation): prevent validation lead from executing arbitrary local commands#63
Open
fix(validation): prevent validation lead from executing arbitrary local commands#63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
runCommandSetvia the system shell, creating a path for command injection and host compromise.Description
selectApprovedLocalValidationCommands(requested, inferred)which dedupes and returns the intersection of the model-requested commands with the deterministicinitialPlan.localValidation.commands.approvedLocalCommands) instead ofvalidationPlan.localValidation.commandswhen invokingrunCommandSetand when populating therequestedCommandsfield for skipped runs.runCommandSetbehavior and tool-wrapper preparation so approved inferred commands run unchanged while any additional LLM-emitted commands are ignored.Testing
npm test -- test/validation.test.ts, which completed successfully (1 file passed, 6 tests passed).npm test -- test/deliver.test.ts; the validation/deliver scenarios executed and produced logs, but the test run output was large and truncated in the execution environment so a final summary could not be captured here.Codex Task