Skip to content

fix(validation): prevent validation lead from executing arbitrary local commands #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ganesh47 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(validation): prevent validation lead from executing arbitrary local commands #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/validation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1412,6 +1412,17 @@ async function runCommandSet(cwd: string, runDir: string, commands: string[]): P
};
}

function selectApprovedLocalValidationCommands(requested: string[], inferred: string[]): string[] {
const approved = new Set(uniqueStrings(inferred));
const selected: string[] = [];
for (const command of uniqueStrings(requested)) {
if (approved.has(command)) {
selected.push(command);
}
}
return selected;
}

async function runValidationSpecialist(options: {
cwd: string;
runId: string;
Expand Down Expand Up @@ -2107,12 +2118,16 @@ export async function runDeliverValidationExecution(options: DeliverValidationEx
};
}

const approvedLocalCommands = selectApprovedLocalValidationCommands(
validationPlan.localValidation.commands,
initialPlan.localValidation.commands
);
const localValidationRecord: DeliverValidationLocalRecord =
result.code === 0
? await runCommandSet(options.cwd, options.paths.stageDir, validationPlan.localValidation.commands)
? await runCommandSet(options.cwd, options.paths.stageDir, approvedLocalCommands)
: {
status: "not-run",
requestedCommands: validationPlan.localValidation.commands,
requestedCommands: approvedLocalCommands,
results: [],
notes: "Local validation commands were skipped because the validation lead did not complete successfully."
};
Expand Down
Loading