Repository navigation
AddToIgs improvements 2: Don't call GcdPara when we can predict it won't make any changes - #236
Merged
Merged
Conversation
Avoid calling GcdPcp(Para) when it will not do anything Assisted-by: Claude Code (Opus 5.5, Fable 5.1)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #236 +/- ##
==========================================
+ Coverage 69.41% 69.44% +0.03%
==========================================
Files 88 88
Lines 12813 12826 +13
==========================================
+ Hits 8894 8907 +13
Misses 3919 3919
🚀 New features to boost your workflow:
|
GcdPara when we can predict it won't make any changes
fingolfin
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #174. That PR does a lot of (sometimes independent) changes, my hope is that it's easier to get that reviewed by splitting it in smaller chunks.
This PR does not depend on #235, though it will have a small merge conflict in the declaration of local vars. It also doesn't have much of an impact, but it sets up a future change from #174 quite nicely.
Original PR disclaimer:
Assisted-by: Claude Code (Opus 5.5, Fable 5.1)