Skip to content

AddToIgs improvements 2: Don't call GcdPara when we can predict it won't make any changes - #236

Merged
fingolfin merged 2 commits into
gap-packages:masterfrom
stertooy:igs-improv-2
Oct 16, 2026
Merged

fingolfin merged 2 commits into
gap-packages:masterfrom
stertooy:igs-improv-2

Conversation

@stertooy

@stertooy stertooy commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Extracted from #174. That PR does a lot of (sometimes independent) changes, my hope is that it's easier to get that reviewed by splitting it in smaller chunks.

This PR does not depend on #235, though it will have a small merge conflict in the declaration of local vars. It also doesn't have much of an impact, but it sets up a future change from #174 quite nicely.

Original PR disclaimer:
Assisted-by: Claude Code (Opus 5.5, Fable 5.1)

Avoid calling GcdPcp(Para) when it will not do anything

Assisted-by: Claude Code (Opus 5.5, Fable 5.1)
@codecov

codecov Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.44%. Comparing base (c7aa72d) to head (91e5d59).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
+ Coverage   69.41%   69.44%   +0.03%     
==========================================
  Files          88       88              
  Lines       12813    12826      +13     
==========================================
+ Hits         8894     8907      +13     
  Misses       3919     3919              
Files with missing lines Coverage Δ
gap/basic/pcppara.gi 92.68% <100.00%> (+0.29%) ⬆️
gap/basic/pcppcps.gi 83.02% <100.00%> (+0.15%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stertooy stertooy changed the title Small optimisations for AddToIgs code (2) AddToIgs improvements 2: Don't call GcdPara when we can predict it won't make any changes Oct 12, 2026
@fingolfin
fingolfin enabled auto-merge (squash) October 16, 2026 22:43
@fingolfin
fingolfin merged commit b5ea5da into gap-packages:master Oct 16, 2026
5 checks passed
@stertooy
stertooy deleted the igs-improv-2 branch October 21, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants