chore(deps): update Native SDK to v0.16.0 - #5452
Conversation
803ebe3 to
20ea3e6
Compare
| @@ -1 +1 @@ | |||
| Subproject commit a1827544e2da7e50517615003288c25380f8d457 | |||
| Subproject commit a99d64efb8d5c614bbcfdab7c7dc737530e5ef7d | |||
There was a problem hiding this comment.
Bug: The P/Invoke call to sentry_close() may fail as the function was likely renamed to sentry_shutdown() in the updated native library, causing a crash on shutdown.
Severity: HIGH
Suggested Fix
Verify if sentry_close() was renamed to sentry_shutdown() in the sentry-native 0.16.0 release. If so, update the DllImport attribute in CFunctions.cs to point to the new function name sentry_shutdown().
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: modules/sentry-native#L1
Potential issue: The update to `sentry-native` version 0.16.0 likely includes breaking
API changes, such as renaming the shutdown function from `sentry_close()` to
`sentry_shutdown()`. The .NET SDK's P/Invoke wrapper still attempts to call the old
function name, `sentry_close()`. This will result in an `EntryPointNotFoundException`
when `SentrySdk.Close()` is executed during normal application shutdown, causing the
application to crash.
Did we get this right? 👍 / 👎 to inform future reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5452 +/- ##
==========================================
+ Coverage 74.68% 74.69% +0.01%
==========================================
Files 512 512
Lines 18722 18722
Branches 3660 3660
==========================================
+ Hits 13983 13985 +2
+ Misses 3866 3865 -1
+ Partials 873 872 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jamescrosswell
left a comment
There was a problem hiding this comment.
Automated approval: eligibility script verdict MERGE (CI green, mergeable, no human change-request, no breaking-change language).
Bumps modules/sentry-native from 0.15.4 to 0.16.0.
Auto-generated by a dependency updater.
Changelog
0.16.0
Features:
sentry_options_set_minidump_flagsfor configuring rawMINIDUMP_TYPEflags. (#1911)cache_overflowdiscards due tocache_max_itemsorcache_max_size. (#1884)sentry_scope_capture_feedbackto capture user feedback against a given scope, matchingsentry_scope_capture_event/_log/_metric. The feedback carries the scope's data layered on top of the global scope, including attachments set on that scope, accepts an optional hint for additional attachments, and returns the feedback's event ID. (#1916)Fixes:
sentry_value_tcontainers while significantly improving scope merge performance with copy-on-write cloning. (#1794)task_for_pidfails (e.g. sandboxed apps), so thread names resolve in crash events from packaged apps. (#1905)stderron shutdown unless debug logging is enabled, so terminal applications stay quiet whendebugis off. (#1910)STATUS_HEAP_CORRUPTION(0xC0000374). (#1909)sentry_options_set_handler_strategy(SENTRY_HANDLER_STRATEGY_CHAIN_AT_START). (#1912)before_sendattachments with local scopes. (#1922)