fix(nitro): Capture errors only through the Nitro error hook - #24952
Merged
Merged
Conversation
Co-Authored-By: OpenAI Codex <codex@openai.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f344b92. Configure here.
Co-Authored-By: OpenAI Codex <codex@openai.com>
nicohrubec
marked this pull request as ready for review
October 1, 2026 16:50
nicohrubec
requested review from
chargome,
logaretm and
s1gr1d
and removed request for
a team
October 1, 2026 16:50
logaretm
approved these changes
Oct 1, 2026
nicohrubec
added a commit
that referenced
this pull request
Oct 2, 2026
) Backport of: #24952 ## Differences to the original PR - The 400-error regression test waits for the flush endpoint's transaction instead of a streamed span, matching v10's default trace lifecycle. - The standard error test checks the hook mechanism on the original `Error` instead of the `HTTPError` wrapper, matching v10's mechanism assignment within linked errors. Fixes #24939 Co-authored-by: OpenAI Codex <codex@openai.com>
47 tasks
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture errors through Nitro's error hook so ordinary thrown errors are reported once and 3xx/4xx HTTP errors stay filtered. The tracing channel continues recording span error status without sending a separate error event.
Adds E2E coverage for an explicitly thrown 400 and updates the standard error test to expect the hook event.
Fixes #24939