Conversation
Companion to getyourguide/public-partner-api#2097, which rejects flags[] values outside the Flags enum with a 400 instead of ignoring them (or returning 503 when they were the only filter). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
clue-gyg
approved these changes
Sep 25, 2026
clue-gyg
left a comment
There was a problem hiding this comment.
✅ Auto-approved
Tiny diff (~4 lines) to OpenAPI description text only, in spec/components/commons/query.yaml and spec/paths/tours.yaml; no schema/type changes, no new endpoints, and it matches the error-response-improvement exception (documenting a 400 for invalid flags[] input without altering happy-path responses or contracts).
FlaviaC-gyg
approved these changes
Sep 25, 2026
3 of 4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Companion to getyourguide/public-partner-api#2097.
GET /{version}/toursnow rejectsflags[]values that are not in the documentedFlagsenum with a 400 (errorCode12), instead of silently ignoring them, or returning an off-contract 503 when the unknown flag was the only filter (the OWASP ZAP probe that fired the Search API 400 monitor on 2026-09-23). Matching is exact and case-sensitive, soPRIVATEis rejected whileprivateis accepted.Changes:
flags[]parameter (spec/components/commons/query.yaml): state that only theFlagsenum values are accepted, matched case-sensitively, and that anything else is rejected with a 400.spec/paths/tours.yaml): add an unsupportedflags[]value to the examples of invalid parameters.No schema or type changes. The
Flagsenum already lists exactly the accepted values, so generated clients are unaffected. Description-only, same shape as #119.Checklist:
🤖 Generated with Claude Code