Skip to content

Pin action SHAs across all workflows and do not mark PR as draft in rebuild workflow - #1419

Merged
mbg merged 3 commits into
mainfrom
mbg/ci/no-draft
Jun 22, 2026
Merged

Pin action SHAs across all workflows and do not mark PR as draft in rebuild workflow#1419
mbg merged 3 commits into
mainfrom
mbg/ci/no-draft

Conversation

@mbg

@mbg mbg commented Jun 22, 2026

Copy link
Copy Markdown
Member

Marking the PR as "draft" in the rebuild workflow is not necessary, because we can now use the "Approve workflow runs" feature in the UI to approve workflow runs for a CI-generated commit.

@mbg
mbg requested a review from henrymercer June 22, 2026 09:35
@mbg mbg self-assigned this Jun 22, 2026
@mbg
mbg requested a review from a team as a code owner June 22, 2026 09:35
Copilot AI review requested due to automatic review settings June 22, 2026 09:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s GitHub Actions workflows to use immutable (SHA-pinned) action references for supply-chain hardening, and adjusts the rebuild workflow behavior so it no longer marks PRs as draft.

Changes:

  • Pin actions/checkout, actions/setup-node, and github/codeql-action usages to specific commit SHAs (with version comments) instead of floating major tags.
  • Remove the gh pr ready --undo step in rebuild.yml so rebuild automation no longer changes PR draft/ready state.
  • Minor workflow formatting consistency updates (e.g., YAML quoting/spacing).
Show a summary per file
File Description
.github/workflows/rebuild.yml Updates pinned actions/checkout SHA/version and removes the command that would revert PRs to draft after rebuilding.
.github/workflows/pr-checks.yml Replaces floating action tags with SHA-pinned references (checkout/setup-node/codeql init).
.github/workflows/codeql-analysis.yml Pins checkout and CodeQL init/analyze actions to specific SHAs.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 3/3 changed files
  • Comments generated: 0

@mbg
mbg enabled auto-merge June 22, 2026 09:42

@henrymercer henrymercer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just one comment.

Comment thread .github/workflows/rebuild.yml
Co-authored-by: Henry Mercer <henry@henrymercer.name>
@mbg
mbg requested a review from henrymercer June 22, 2026 11:34
@mbg
mbg merged commit f758b4e into main Jun 22, 2026
9 checks passed
@mbg
mbg deleted the mbg/ci/no-draft branch June 22, 2026 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants