Skip to content

fix: clarify GitHub device-flow and classic PAT login copy - #3298

Merged
setchy merged 4 commits into
mainfrom
refactor/fix-auth-terminology-support
Oct 29, 2026
Merged

setchy merged 4 commits into
mainfrom
refactor/fix-auth-terminology-support

Conversation

@setchy

@setchy setchy commented Sep 11, 2026 •

Copy link
Copy Markdown
Member

Summary

Follow-up to #3449, which already renamed the auth methods (Gitify OAuth App / Custom OAuth App) and migrates persisted accounts. This PR is copy-only:

  • Device-flow screen title: "Authorize Gitify's OAuth App" (custom apps keep their own title).
  • PAT screen keeps the "Login with Personal Access Token" heading, uses the placeholder "Your classic token (40 characters)", and notes: "Use a classic personal access token; fine-grained tokens are not supported."

@github-actions github-actions Bot added the refactor Refactoring of existing feature label Sep 11, 2026
@sonarqubecloud

Copy link
Copy Markdown

@setchy
setchy force-pushed the refactor/fix-auth-terminology-support branch from a24bb93 to 0f720df Compare October 25, 2026 18:34
@setchy setchy changed the title refactor: align gh terminology refactor: clarify GitHub auth method terminology Oct 25, 2026
@setchy
setchy marked this pull request as ready for review October 25, 2026 18:45
@setchy
setchy requested a review from afonsojramos as a code owner October 25, 2026 18:45
@setchy
setchy marked this pull request as draft October 25, 2026 18:48
- Device-flow screen title: "Authorize Gitify's OAuth App".
- PAT screen: "Login with Classic Personal Access Token", and note that
  fine-grained tokens are not supported.
@setchy
setchy force-pushed the refactor/fix-auth-terminology-support branch from 0f720df to 97137d7 Compare October 28, 2026 23:49
@setchy setchy changed the title refactor: clarify GitHub auth method terminology fix: clarify GitHub device-flow and classic PAT login copy Oct 28, 2026
@setchy
setchy marked this pull request as ready for review October 28, 2026 23:49
@github-actions github-actions Bot added bug Something isn't working and removed refactor Refactoring of existing feature labels Oct 28, 2026
@sonarqubecloud

Copy link
Copy Markdown

@setchy
setchy merged commit 9687027 into main Oct 29, 2026
19 checks passed
@setchy
setchy deleted the refactor/fix-auth-terminology-support branch October 29, 2026 00:16
@github-actions github-actions Bot added this to the Release 8.0.0 milestone Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

1 participant