Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions src/renderer/routes/github/DeviceFlowAuthorize.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ describe('renderer/routes/github/DeviceFlowAuthorize.tsx', () => {
});

expect(screen.getByText('Receive notifications for:')).toBeInTheDocument();
expect(screen.getByText("Authorize Gitify's OAuth App")).toBeInTheDocument();
expect(screen.getByRole('button', { name: /^Public Limited/ })).toBeInTheDocument();
expect(screen.getByRole('button', { name: /Public and Private/ })).toBeInTheDocument();

Expand Down
2 changes: 1 addition & 1 deletion src/renderer/routes/github/DeviceFlowAuthorize.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ export function GitHubDeviceFlowAuthorize({

return (
<Page testId="Login With Device Flow">
<Header icon={SignInIcon}>{title ?? 'Authorize with GitHub'}</Header>
<Header icon={SignInIcon}>{title ?? "Authorize Gitify's OAuth App"}</Header>

<Contents scrollFade>
{error && (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,16 @@ describe('renderer/routes/github/LoginWithPersonalAccessToken.tsx', () => {
expect(screen.getByRole('button', { name: 'Login' })).toBeInTheDocument();
});

it('explains that only classic tokens are supported', () => {
renderWithProviders(<GitHubLoginWithPersonalAccessTokenRoute />);

expect(
screen.getByText(
/Use a classic personal access token; fine-grained tokens are not supported/,
),
).toBeInTheDocument();
});

it('let us go back', async () => {
renderWithProviders(<GitHubLoginWithPersonalAccessTokenRoute />);

Expand Down
4 changes: 2 additions & 2 deletions src/renderer/routes/github/LoginWithPersonalAccessToken.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ export function GitHubLoginWithPersonalAccessTokenRoute() {
hostnameCaption="Change only if you are using GitHub Enterprise Server"
hostnamePlaceholder="github.com"
title="Login with Personal Access Token"
tokenPlaceholder="Your generated token (40 characters)"
tokenPlaceholder="Your classic token (40 characters)"
tokenSettingsCaption="on GitHub to paste the token below."
tokenSettingsLabel="Generate a PAT"
>
<Text as="i" className="text-xs">
The{' '}
Use a classic personal access token; fine-grained tokens are not supported. The{' '}
<Tooltip direction="se" text={formatRecommendedOAuthScopes()}>
<button type="button">
<Text as="u">recommended scopes</Text>
Expand Down
Loading