Repository navigation
feat: build with pluginpack 0.12, which emits Agent Plugins packages for Codex - #35
Draft
steve-calvert-glean wants to merge 2 commits into
Draft
steve-calvert-glean wants to merge 2 commits into
steve-calvert-glean wants to merge 2 commits into
Conversation
…for Codex pluginpack 0.12 changes the codex target's default output from .codex-plugin/plugin.json + .mcp.json to an Agent Plugins 1.0 package: a root plugin.json with Codex settings under extensions["com.openai"], and mcp.json. Claude and Cursor output is unchanged apart from the rename below. - Drop "cwd": "." from the Codex MCP override. Agent Plugins rejects it, and an omitted cwd already means the plugin root, so ./mcp/start.mjs still resolves. - Rename the glean_run skill to glean-run. Agent Skills names allow only lowercase letters, digits and hyphens, and conforming clients skip glean_run. The rename applies to every target, so the Claude and Cursor slash name changes too.
Refresh the lockfile now that @gleanwork/pluginpack 0.12.0 is on npm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
@gleanwork/pluginpack0.12.0 changes thecodextarget's default output from.codex-plugin/plugin.json+.mcp.jsonto an Agent Plugins 1.0 package (gleanwork/pluginpack#38). With our current sources, the new version fails in two places:"cwd": "."inoverrides/codex/glean/mcp/config.json. Agent Plugins accepts only a./path or a path under${PLUGIN_ROOT}/${PLUGIN_DATA}.validatefails on theglean_runskill. Agent Skills names allow only lowercase letters, digits and hyphens, and conforming clients skip the skill.Change
@gleanwork/pluginpackto^0.12.0.cwdfrom the Codex MCP override. In Agent Plugins, an omittedcwdmeans the plugin root, which is what"."meant before, so./mcp/start.mjsstill resolves.glean_runtoglean-runinshared/glean/mcp/. This applies to every target, because the skill ships from the MCP server's file list. User-visible: the Claude and Cursor slash name changes fromglean_runtoglean-run.Output
I built this against a packed
pluginpack(mainplus gleanwork/pluginpack#41, the 0.12.0 contents) and compared it withmainbuilt on 0.11.0:glean_run→glean-runrename.plugins/<name>/plugin.json(with$schemaandextensions["com.openai"].interface) andmcp.jsonreplace.codex-plugin/plugin.jsonand.mcp.json. The marketplace file stays the same. Codex needs v0.146 or later to read the new layout.npm test(build + validate for all 3 targets) passes, and so doesnpm run test:bundle(434 tests).Before merging
@gleanwork/pluginpack0.12.0, then runnpm installhere to updatepackage-lock.json. CI fails until then, because the lockfile still pins 0.11.x.feat!:.