Skip to content

Fix empty array edge cases in coxphfit - #488

Open
Sonu0305 wants to merge 3 commits into
gnu-octave:mainfrom
Sonu0305:fix-coxphfit-empty
Open

Sonu0305 wants to merge 3 commits into
gnu-octave:mainfrom
Sonu0305:fix-coxphfit-empty

Conversation

@Sonu0305

Copy link
Copy Markdown
Contributor

No description provided.

@pr0m1th3as

Copy link
Copy Markdown
Member

MATLAB's result for no data comes from a singular matrix inverse (covb -Inf on the diagonal, se Inf, p and LikelihoodRatioTestP 1), and its "rank deficient" warning names the wrong cause. We don't replicate that, and MATLAB's own mnrfit, mvregress and robustfit error on empty input. Keep coxphfit erroring when no complete observation remains; a clearer message for empty input is welcome. Also, warning ("off", ...) takes an identifier, not the message text, so that test cannot work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants