Skip to content

Fix empty array edge cases in coxphfit #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pr0m1th3as merged 3 commits into from
Sep 16, 2026
+14 −3
Merged

Fix empty array edge cases in coxphfit #488

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa05c17
Fix empty array edge cases in coxphfit
Sonu0305 Sep 15, 2026
21d39fc
Fix case in coxphfit error and format, revert T checks
Sonu0305 Sep 16, 2026
5f21777
Fix formatting
Sonu0305 Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions inst/Regression/coxphfit.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,10 @@
endif

## --- X and T -----------------------------------------------------------
if (! (isnumeric (X) && isreal (X) && ismatrix (X) && ! isempty (X)))
if (! (isnumeric (X) && isreal (X) && ismatrix (X)))
error ("coxphfit: X must be a real numeric matrix.");
endif
if (! (isnumeric (T) && isreal (T) && ! isempty (T)))
if (! (isnumeric (T) && isreal (T)))
error ("coxphfit: T must be a real numeric vector.");
endif
## T is either a vector of event times or, in the counting process form, an
Expand All @@ -177,7 +177,7 @@
error (strcat ("coxphfit: each row of T must give a (start, stop]", ...
" interval with start strictly less than stop."));
endif
elseif (isvector (T))
elseif (isvector (T) || isempty (T))
T = T(:);
Tstart = -Inf (numel (T), 1);
else
Expand All @@ -188,6 +188,11 @@
if (rows (X) != n)
error ("coxphfit: T must have one element for each row of X.");
endif

if (n == 0)
error ("coxphfit: X and T must contain at least one observation.");
endif

p = columns (X);

## --- name/value pairs --------------------------------------------------
Expand Down Expand Up @@ -947,3 +952,9 @@
## A constant column is reported, not silently absorbed
%!warning<coxphfit: the Cox model cannot have a constant term in X.> ...
%! coxphfit ([X, ones(10,1)], T);

## Edge cases with empty arrays
%!error <coxphfit: X and T must contain at least one observation.> ...
%! coxphfit ([], [])
%!error <coxphfit: X and T must contain at least one observation.> ...
%! coxphfit (zeros (0, 3), zeros (0, 1))