Skip to content

chore: clean up client logic now diversion config is fully deployed - #14815

Merged
mutianf merged 4 commits into
googleapis:mainfrom
mutianf:cleanup
Oct 29, 2026
Merged

mutianf merged 4 commits into
googleapis:mainfrom
mutianf:cleanup

Conversation

@mutianf

@mutianf mutianf commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@mutianf
mutianf requested review from a team as code owners October 28, 2026 19:17

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the fallback to global session load mechanism from the SessionScope enum, simplifying the class and ensuring resolveSessionLoad always returns 0f when no diversion configuration is present. The corresponding tests have been updated to reflect this change. However, removing the @SuppressWarnings("deprecation") annotation in SessionScopeTest will trigger compilation warnings because the test class still references the deprecated sessionLoad method.

mutianf and others added 2 commits October 28, 2026 15:26
…loud/bigtable/data/v2/internal/util/SessionScopeTest.java

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@mutianf
mutianf enabled auto-merge (squash) October 29, 2026 14:51
@mutianf
mutianf merged commit 778c39c into googleapis:main Oct 29, 2026
207 checks passed
@mutianf
mutianf deleted the cleanup branch October 29, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants