Repository navigation
chore: clean up client logic now diversion config is fully deployed - #14815
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the fallback to global session load mechanism from the SessionScope enum, simplifying the class and ensuring resolveSessionLoad always returns 0f when no diversion configuration is present. The corresponding tests have been updated to reflect this change. However, removing the @SuppressWarnings("deprecation") annotation in SessionScopeTest will trigger compilation warnings because the test class still references the deprecated sessionLoad method.
…loud/bigtable/data/v2/internal/util/SessionScopeTest.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
nimf
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.