docs: Format resource names in RPC samples#5504
docs: Format resource names in RPC samples#5504amanda-tarafa merged 1 commit intogoogleapis:mainfrom
Conversation
product-auto-label
Bot
added
the
samples
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5504 +/- ##
==========================================
- Coverage 97.79% 97.79% -0.01%
==========================================
Files 219 219
Lines 50217 50217
==========================================
- Hits 49109 49108 -1
- Misses 1108 1109 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amanda-tarafa
force-pushed
the
samples-resource-name
branch
2 times, most recently
from
92ba4e8 to
37c9dc8
Compare
amanda-tarafa
changed the title
|
Generated with googleapis/librarian#5530 minus some |
amanda-tarafa
force-pushed
the
samples-resource-name
branch
from
37c9dc8 to
a91b3a1
Compare
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
I won't be able to review the code in sidekick, just a small observation on the output.
@coryan Did you meant to leave a comment here about the output, or is this referring to the comments you left on the librarian PR (those are already addressed). I don't see any other comment here though. Thanks. |
Yes, but apparently I forgot how to use computers. Fixed. |
amanda-tarafa
force-pushed
the
samples-resource-name
branch
3 times, most recently
from
0fef392 to
a98fec7
Compare
amanda-tarafa
force-pushed
the
samples-resource-name
branch
from
a98fec7 to
f0c1a23
Compare
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
For a future PR: the PredictionService in aiplatform is pretty important but also is super ad-hoc, so the examples are not as awesome as the other examples. Some List*() things are missing the parent format too.
| /// async fn sample( | ||
| /// parent: &str, | ||
| /// ) -> anyhow::Result<()> { |
There was a problem hiding this comment.
For a future PR, I wonder why this parent (which I am sure is a project) is not captured.
There was a problem hiding this comment.
Because it's a reference to a resource outside of this package, so we don't have the resource definition so we don't know the patterns. See here.
Not sure if there's much we can do about it, except finding and loading this external resources. I think that's being done for mixins etc. already, but I'm not sure.
2 participants
No description provided.