Repository navigation
ci: set explicit Debian maintainer identity for package gate - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package gate (scripts/package_deb.sh via verify.sh/test_deb.sh) derives the maintainer from the git HEAD author and rejects bot noreply addresses, which fails dependabot PRs #11, #12 and #13 at 'Strict release verification' (
Set DEBEMAIL to the actual maintainer contact; no invented default is used.).This PR now reads the maintainer identity from repository variables in ci.yml and release.yml:
DEBEMAIL: ${{ vars.DEBEMAIL }}andDEBFULLNAME: ${{ vars.DEBFULLNAME || 'grloper' }}. No personal address is committed. A first step fails with "Set repository variable DEBEMAIL" if it is empty. CONTRIBUTING.md documents this.Owner action required: create repository variable
DEBEMAILin Settings > Secrets and variables > Actions > Variables (the maintainer contact; optionallyDEBFULLNAME). CI on this PR will be red until it is set. The variable has NOT been created by automation; it will only be set if the owner approves.Not merged/tagged. Note: an earlier commit on this branch contained a personal address; squash-merge to keep it out of main history.