feat(persistent-worker): critic ping-pong protocol (#110)#140
Merged
Conversation
Routes a typed CriticReport into the AWAITING_CRITIC outbound edge:
- approve -> MERGED (auto-merge already in flight)
- request_changes -> REVISING (counter bumps via
store.increment_iterations, follow-up worker
dispatched with the SDK session_id resumed and
the critic comments serialised verbatim)
- block (sev1) -> ABANDONED + PR labelled loop:needs-review
The verbatim contract — "no summarisation" — is delivered by
format_critic_followup_prompt(): every Finding's message, file/line,
and severity/category tag is rendered into the next prompt as-is, so
the resumed SDK worker sees exactly what the critic wrote.
dispatch_revision is a callback so unit tests can capture the prompt
and resume kwargs without actually spinning up an SDK session; the
runner wires the real dispatcher in a follow-up. A dispatch crash is
caught at the boundary so the FSM edge + counter bump are never
undone — the next tick can retry from REVISING.
Iteration-cap enforcement (#111) stays in enforce_critic_iteration_cap
and is layered on top by the runner; this handler is the pure
verdict→state router.
Tests cover the four acceptance cases plus adversarial paths:
unknown verdict no-ops, gh label failure can't undo ABANDONED,
dispatch crash can't undo REVISING, wrong starting state raises
InvalidTransition.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Owner
Author
|
Source issue #110 was closed mid-flight (state: closed). Loop refusing auto-merge. Reopen the issue OR merge manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #110.
Summary
CriticReportthrough the AWAITING_CRITIC outbound edge.approve→ MERGED;request_changes→ REVISING (+ counter bump + verbatim-prompt dispatch);block→ ABANDONED + labelloop:needs-review.format_critic_followup_prompt()serialises findings into the next worker prompt verbatim — every finding's message, file/line, and[sev/category]tag are preserved as the critic wrote them.handle_critic_verdict()is the verdict→state router; it does NOT enforce the iteration cap (that's feat(persistent-worker): crash recovery — resume non-terminal sessions at boot #111).resume=<sdk_session_id>so the prompt cache stays warm.Acceptance coverage
test_approve_transitions_to_merged— APPROVE → MERGED.test_request_changes_transitions_to_revising_and_bumps_counter— REQUEST_CHANGES → REVISING,critic_iterationsbumps viastore.increment_iterations.test_block_transitions_to_abandoned_and_labels_pr— BLOCK → ABANDONED + PR labelledloop:needs-review.test_request_changes_dispatches_followup_with_verbatim_critic_comments— next dispatch prompt contains the critic comments verbatim.Adversarial coverage
dispatch_revisioncrash does not undo REVISING / counter bump.InvalidTransition.KeyError.pr_urlskips the label call.Out of scope (separate tickets)
Test plan
pytest tests/test_critic_ping_pong.py(12 passed)pytest tests/test_critic_iteration_cap.py tests/test_persistent_dispatch.py tests/test_critic.py(35 passed)ruff checkclean🤖 Generated with Claude Code