Repository navigation
fix: return SSE responses through hapi's lifecycle - #7
Merged
Merged
Conversation
Route cors/security headers and onPreResponse now apply to SSE responses. Compression is disabled: zlib buffers events. Closes #6
Marsup
reviewed
Oct 7, 2026
SSE responses are compressed when the client accepts gzip or deflate, flushed per event through the compression route option. Turn off with server compression: false or the text/event-stream mime override.
Contributor
|
Requalifying as minor considering the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handlers now return a hapi response that wraps the session's stream instead of writing to
raw.resand abandoning. As a result, routecors/securitysettings andonPreResponseapply to SSE responses, and the refuse/complete paths send real 204s.SSE responses are compressed when the client accepts gzip or deflate. SSE routes set hapi's
compressionroute option toflush: Z_SYNC_FLUSH, so each event goes out as soon as it is written. Compression can be turned off with servercompression: false, or for SSE only with atext/event-streammime override.onPostResponsenow fires when the stream ends. A client disconnect is recorded as a 499.Closes #6