Skip to content

fix(desktop): Start menu only, and the Humanize mark in the Windows installer and toasts - #518

Merged
futrime merged 2 commits into
mainfrom
fix/windows-start-menu-only
Oct 24, 2026
Merged

futrime merged 2 commits into
mainfrom
fix/windows-start-menu-only

Conversation

@futrime

@futrime futrime commented Oct 24, 2026 •

Copy link
Copy Markdown
Member

Found while testing the installed Windows app end to end.

What was wrong

  • Desktop shortcut nobody asked for. Tauri's NSIS template makes one outright on a silent or passive install, and its finish page offers one already ticked.
  • No logo in the installer. The setup's own icon, its sidebar and its header were NSIS's stock pictures.
  • No logo in toasts. Windows drew a blank page in the corner of each toast.

What this changes

  • Installer hook. desktop/src-tauri/windows/hooks.nsh:
    • leaves the finish page's Create desktop shortcut unticked (MUI_FINISHPAGE_SHOWREADME_NOTCHECKED);
    • removes the shortcut a silent or passive first install makes;
    • keeps one an update finds.
  • Installer pictures. installerIcon is the app's icon.ico. sidebarImage and headerImage are BMPs drawn from windows/sidebar.svg and windows/header.svg by pnpm nsis-images (resvg plus a small BMP writer), as dmg-background does for the disk image.
  • Toast logo. Each toast carries the mark itself as appLogoOverride, from a copy the app writes to its cache directory. A follow-up PR moves that copy to ProgramData, because Windows can leave out a toast picture kept under AppData.
    • Registering the app ID in the registry (AppUserModelId\…\IconUri) did not help here.
    • Neither did giving the Start menu shortcut an explicit icon.
  • Spec and docs. features/desktop.md §3.15–3.16 and §9.1, and docs/user/desktop-windows.md.

Tested on Windows 11 with WSL Debian

  • Silent install: Start menu shortcut only. Uninstall removes it.
  • Interactive install: the finish page shows the shortcut unticked, and none is made.
  • The setup .exe icon, title bar, sidebar and header show the mark.
  • A toast posted from the page shows the mark.
  • cargo fmt, clippy -D warnings and cargo test pass on Windows.

@futrime
futrime enabled auto-merge October 24, 2026 14:31
…umanize mark

The installer put a shortcut on the desktop unasked: silent and passive installs made one
outright, and the finish page offered one ticked. It now offers it unticked and takes back the
one a silent or passive first install makes, keeping one an update finds.

Its own icon, sidebar and header were NSIS's stock pictures; they are now the mark, drawn by
pnpm nsis-images from the SVGs beside them.
Windows drew a blank page in a toast's corner, not finding the app's icon through its Start menu
shortcut. The toast now carries the mark itself, as appLogoOverride, from a copy the app writes
to its cache directory.
@futrime
futrime added this pull request to the merge queue Oct 24, 2026
Merged via the queue into main with commit cd8c8bf Oct 24, 2026
15 checks passed
@futrime
futrime deleted the fix/windows-start-menu-only branch October 24, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant