Repository navigation
fix(desktop): Start menu only, and the Humanize mark in the Windows installer and toasts - #518
Merged
Merged
Conversation
futrime
enabled auto-merge
October 24, 2026 14:31
…umanize mark The installer put a shortcut on the desktop unasked: silent and passive installs made one outright, and the finish page offered one ticked. It now offers it unticked and takes back the one a silent or passive first install makes, keeping one an update finds. Its own icon, sidebar and header were NSIS's stock pictures; they are now the mark, drawn by pnpm nsis-images from the SVGs beside them.
Windows drew a blank page in a toast's corner, not finding the app's icon through its Start menu shortcut. The toast now carries the mark itself, as appLogoOverride, from a copy the app writes to its cache directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while testing the installed Windows app end to end.
What was wrong
What this changes
desktop/src-tauri/windows/hooks.nsh:MUI_FINISHPAGE_SHOWREADME_NOTCHECKED);installerIconis the app'sicon.ico.sidebarImageandheaderImageare BMPs drawn fromwindows/sidebar.svgandwindows/header.svgbypnpm nsis-images(resvg plus a small BMP writer), asdmg-backgrounddoes for the disk image.appLogoOverride, from a copy the app writes to its cache directory. A follow-up PR moves that copy toProgramData, because Windows can leave out a toast picture kept underAppData.AppUserModelId\…\IconUri) did not help here.features/desktop.md§3.15–3.16 and §9.1, anddocs/user/desktop-windows.md.Tested on Windows 11 with WSL Debian
.exeicon, title bar, sidebar and header show the mark.cargo fmt, clippy-D warningsandcargo testpass on Windows.