fix(debt): pay Debtfile down to its ceilings (Debt ratchet green) - #1078
Open
hyperpolymath wants to merge 1 commit into
Open
hyperpolymath wants to merge 1 commit into
hyperpolymath wants to merge 1 commit into
Conversation
The required `governance / Debt ratchet` check has been red on main since #1061 because two measured counts sat above their ceilings: docs-md-not-adoc count 2 > ceiling 1 gate-scripts-without-tests live 45 > ceiling 40 (committed 43, stale) This pays the debt rather than raising any ceiling: - docs/tier3-gate-probe.md -> .adoc (CC-BY-SA-4.0 header added; no inbound references). docs-md-not-adoc measures 1. - Five new tests, each proven able to fail by killing two mutants of its gate (10 of 10 killed, `bash -n` checked first): uuid-v7-test.sh -> check-uuid-v7.sh (11 assertions) mustfile-structure-test.sh -> check-mustfile-structure.sh (11) language-guide-test.sh -> check-language-guide.sh (13) shell-test-suite-test.sh -> run-shell-test-suite.sh (14) descriptile-policy-test.sh -> check-descriptile-policy.sh (11) gate-scripts-without-tests measures 40. The uuid-v7 and descriptile tests assemble their non-conforming fixtures from fragments at runtime: both gates scan this repository (scripts/*.sh as a pathspec matches scripts/tests/), so a literal fixture would turn the real gate red on its own test. Counts are set to the measured values. No ceiling is changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WPSJ7fBhVAMcpSffCBWUDo Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com>
Contributor
|
Warning Review limit reachedNext included review available in 21 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The required check
governance / Debt ratchethas been red onmainsince #1061, and it blocks every PR, #1067 included. Two measured counts sat above their ceilings in.machine_readable/Debtfile.a2ml:docs-md-not-adocgate-scripts-without-testsThis PR pays the debt down. No ceiling is changed.
What
docs/tier3-gate-probe.md→docs/tier3-gate-probe.adoc: same content, with a CC-BY-SA-4.0 header added (the licensing policy's docs licence). Nothing references the file.Five new tests. Each gate had never been shown able to fail.
uuid-v7-test.shcheck-uuid-v7.shmustfile-structure-test.shcheck-mustfile-structure.shlanguage-guide-test.shcheck-language-guide.shshell-test-suite-test.shrun-shell-test-suite.shdescriptile-policy-test.shcheck-descriptile-policy.sh-e· never set status=1)Every mutant was checked with
bash -nbefore its red result was trusted.The uuid-v7 and descriptile tests assemble their non-conforming fixtures at runtime. Both gates scan this repository (
uuid-v7.yml, andscripts/*.shas a pathspec matchesscripts/tests/), so a literal fixture would turn the real gate red on its own test. I ran both real gates over the branch to confirm this: rc=0.Verified locally
check-debtfile-structure.sh: OK (8 entries)check-debt-ratchet.sh <base sha bd9313a6>: OK, every ceiling unchangedFindings, filed separately (not fixed here)
check-uuid-v7.shhas a greedysed .*that checks only the last UUID on each line. A line reading<v4> <v7>passes (rc=0);<v7> <v4>is caught.gate-scripts-without-testsprobe can't seescripts/tests/actions-policy-486-test.sh. That file already exercisescheck-actions-policy.sh,set-allowed-actions.shandrsr-selfaudit.sh, so the probe over-counts untested scripts by up to 3.Unblocks #1067.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WPSJ7fBhVAMcpSffCBWUDo